Remove old kubernetes-build-deploy serviceaccount from lagoon-remote #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry, wrong button. |
shreddedbacon
force-pushed
the
remove-kubernetesbuilddeploy
branch
from
b44ebf7 to
ac51b9a
Compare
|
Now that #608 has been merged, and is the current method for long lived tokens to use for SSH in lagoon-core, this PR should merge so we can remove the old references |
|
merging in #627 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lagoon-build-deploycreates its own service account now, and this service account should be the one used in the Lagoon API.This is possibly a breaking change (removing a cluster token), in which Lagoon operators may need to update their Lagoon API
openshift/kubernetestoken for the respective clusters to use the token provided by thelagoon-build-deployservice account if they are not already using this.closes #294