Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustment to where application caches are made in the build process #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bryangruneberg
Copy link
Contributor

I dug into Laravel and I had misunderstood what it does actually. These clear and caches don't need access to the DB, Redis, or the running app - so doing them in the cli.dockerfile seems way better.

This probably needs testing though!

@bomoko
Copy link
Contributor

bomoko commented Aug 8, 2024

@bryangruneberg - This makes sense - is none of this calculated at run time though? None of this conceivably needs access to the DB, etc.?

@tobybellwood
Copy link
Member

php artisan optimize:clear will attempt to clear the keys in the default cache backend, which is usually defaulted to the db (or redis), which aren't available in the Dockerfile - this needs to be a post-rollout

https://laravel.com/docs/11.x/deployment#optimization
https://laravel.com/docs/11.x/cache#configuration

@fruitl00p
Copy link

fruitl00p commented Aug 20, 2024

Just to chime in: php artisan optimize:clear and php artisan optimize do all the cache/clearing that you need. (seen in #9)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants