-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: tables support #2573
feat: tables support #2573
Conversation
This is a much-needed feature. Checks seem to pass, except for the backend ones that haven't run and aren't relevant. |
Actually this is not quite merge-ready, because using a regex is quite limiting to determine the validity of a markdown table expression Also, inserting a wrongly formatted table alongside other tables, breaks some of them (even if they have a correct syntax) Anyway, it's a good start I think, I'll solve these parsing issues |
Sorry for the multiple commits, it was more difficult than I thought. Right now, this PR pass most of the formatting tests found in the markdown-it test suite The ones actually failing are related to backlash and backticks escaping (not supported right now in the parser), but this is not related to this table extension, so maybe for a future PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The syntax of table
is really hard to implement with regular. Thanks for your contribution.
Column alignment is supported, as well as pipe escaping
Should fix Issue #1843