Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - HTML Proofer: fix Performance Research broken link #2589

Closed
2 tasks done
mahoneycm opened this issue Apr 2, 2024 · 5 comments · May be fixed by #2609
Closed
2 tasks done

USWDS-Site - HTML Proofer: fix Performance Research broken link #2589

mahoneycm opened this issue Apr 2, 2024 · 5 comments · May be fixed by #2609
Assignees
Labels
Affects: Guidance Relates to guidance Is: Broken Link A broken link Type: Bug A problem in the code

Comments

@mahoneycm
Copy link
Contributor

mahoneycm commented Apr 2, 2024

Describe the bug

When testing HTML Proofer ignored codes, I found multiple broken links throughout the site.

Steps to reproduce the bug

Visit any of the following links which can be found on the respective USWDS pages:

Note

Showcase links resolved by #2586

Expected Behavior

Links should be updated or removed.

Screenshots

No response

System setup

No response

Additional context

I found this error after removing --ignore-status-codes 0. Unfortunately, some of the results were false positives, so we'll need to continue ignoring error code 0.

Code of Conduct

@mahoneycm mahoneycm added the Type: Bug A problem in the code label Apr 2, 2024
@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Apr 2, 2024
@mahoneycm mahoneycm added Is: Broken Link A broken link Affects: Guidance Relates to guidance labels Apr 2, 2024
@brunerae brunerae changed the title USWDS-Site - HTML Proofer: Broken links April '24 USWDS-Site - HTML Proofer: fix Performance Research broken link Apr 4, 2024
@brunerae brunerae removed the Status: Triage We're triaging this issue and grooming if necessary label Apr 4, 2024
@brunerae brunerae moved this to Scheduled in USWDS Core Project Data Apr 4, 2024
@finekatie
Copy link
Contributor

Updating content on Performance-related pages is covered by #2542, so for this issue, I'm simply going to remove the link from the page.

@finekatie
Copy link
Contributor

This will be closed by #2609

@finekatie finekatie moved this from Scheduled to Review in USWDS Core Project Data Apr 9, 2024
@finekatie
Copy link
Contributor

After copy updates in PR, waiting for review from @sarah-sch and hoping to get ffr and merge after that.

@finekatie
Copy link
Contributor

Sarah and Charlie approved. Added Dan and Anne for approval and added message in PR.

@mejiaj
Copy link
Contributor

mejiaj commented May 3, 2024

Closing as resolved.

@mejiaj mejiaj closed this as completed May 3, 2024
@github-project-automation github-project-automation bot moved this from Review to Done in USWDS Core Project Data May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Affects: Guidance Relates to guidance Is: Broken Link A broken link Type: Bug A problem in the code
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants