Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USWDS-Site - In-page Nav: Update custom header offset #3071

Open
mahoneycm opened this issue Jan 23, 2025 · 2 comments · May be fixed by #3039
Open

USWDS-Site - In-page Nav: Update custom header offset #3071

mahoneycm opened this issue Jan 23, 2025 · 2 comments · May be fixed by #3039
Assignees

Comments

@mahoneycm
Copy link
Contributor

Description

Changes to in-page nav in USWDS 3.1.2 will affect behaviors on site. As captured in testing (#2978), we'll need to update our custom offset to work with the new package.

Important

We'll need to update the header offset logic on our website to account for this change.

Installing this branch on Site did resolve the bug where nested headers would cause the window to scroll to the top of the page but due to our custom JS the offset was not calculated correctly.

Originally posted by @mahoneycm in uswds/uswds#5878 (comment)

@github-actions github-actions bot added the Status: Triage We're triaging this issue and grooming if necessary label Jan 23, 2025
@mejiaj mejiaj linked a pull request Jan 23, 2025 that will close this issue
22 tasks
@mejiaj
Copy link
Contributor

mejiaj commented Jan 23, 2025

This issue is small, let's cherry-pick the commit in #3039 and close.

@mahoneycm to look into some custom javascript that might affect this.

@mejiaj mejiaj moved this to In progress in USWDS Core Project Data Jan 23, 2025
@mejiaj mejiaj added Added during Sprint and removed Status: Triage We're triaging this issue and grooming if necessary labels Jan 23, 2025
@mahoneycm
Copy link
Contributor Author

Confirmed that sidenav.js and scroll-to-top-for-hash.js do not interfere with this work and do not need to be updated to prevent regression 👍

@amyleadem amyleadem removed their assignment Jan 27, 2025
@mejiaj mejiaj moved this from In progress to Review in USWDS Core Project Data Jan 27, 2025
@mejiaj mejiaj moved this from Review to Done in USWDS Core Project Data Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants