Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested CV fails if X_extra is not included in splitter evaluate call #242

Open
bafflerbach opened this issue Jul 26, 2022 · 1 comment
Open
Labels

Comments

@bafflerbach
Copy link
Contributor

A student in skunkworks had this error when running nested CV while having not set X_extra during data loading leading to X_extra being empty. This can be reproduced by modifying the final tutorial splitter to not include the X_extra input in the splitter call itself, or probably by just not setting X_extra during data loading (and subsequently dropping the meta data from feature set manually which i think is what the student did).

The error is:
"Nonetype" object has no attribute columns
from line 603 in data_splitters.py

The error occurs because the code is assuming X_extra exists and has columns when trying to write output files. So there should either be a check earlier to make sure writing this file is appropriate or a warning to make sure to include it, maybe both?

@bafflerbach
Copy link
Contributor Author

bafflerbach commented Jul 26, 2022

An additional thing the student noted is that the error seemed sensitive to whether or not the plots input had additional types included. I'm not able to reproduce this however so may just be an error in their script and not a bug in and of itself.

plots = ["Error"]
did not result in the same error

plots = ["Error","Histogram","Scatter"]
Still had the error even when X_extra was set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant