Qsk cmake find package #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rick-vogel
commented
Dec 21, 2023
|
|
||
| find_package(QSkinny REQUIRED) | ||
|
|
||
| # TODO we don't delivery the qsk macros |
There was a problem hiding this comment.
@uwerat we need to discuss whether we want to deliver the qsk_add_* functions
|
|
||
| add_subdirectory(../iotdashboard ${CMAKE_CURRENT_BINARY_DIR}/../iotdashboard) | ||
|
|
||
| # TODO we don't delivery the support library |
There was a problem hiding this comment.
@uwerat can we deliver the support library?
| @@ -483,6 +483,10 @@ target_include_directories(${target} PUBLIC | |||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/layouts> | |||
| $<BUILD_INTERFACE:${CMAKE_CURRENT_LIST_DIR}/nodes>) | |||
|
|
|||
| target_include_directories(${target} | |||
| INTERFACE | |||
| $<INSTALL_INTERFACE:${QSK_INSTALL_HEADERS}>) | |||
There was a problem hiding this comment.
@uwerat this line makes it that cmake can automatically generate the (library) target's include directories
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reintegration of QSkinny CMake Find Module generation from: #291
Relates to: #119
Relates to: #351 (comment)
Usage
cmake \ -S <your source director> \ -B <your build director> \ -G "<your generator>" \ # optional e.g. "Unix Makefiles"|"Ninja"|... -DCMAKE_BUILD_TYPE=<your build type> \ # optional e.g. Release|Debug|RelWithDebInfo|... -DCMAKE_PREFIX_PATH:PATH="<your qt prefix path>" \ # add qt's root directory e.g. C:\sdk\Qt\5.15.2\msvc2019_64 -DQt5_DIR:PATH="<your qt cmake directory>" \ # add Qt*_DIR e.g. C:\sdk\Qt\5.15.2\msvc2019_64\lib\cmake\Qt5 -DQSkinny_DIR:PATH=<your qskinny install root directory>/lib/cmake/QSkinny