Bug/Search for Qt6 then Qt5 before building #355
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug with find_package in which the ordering is not respected on Linux:
Linux Bug
This makes the
qsk_setup_Qt
macro always load Qt5 (as opposed to suggested practices).This will check for the Qt6 first then fallback to Qt5 if not found, thus replicating the best practice behavior.
To target a specific version pass
QSK_QT_VERSION
to the cmake build command:$ cmake -DQSK_QT_VERSION=Qt5 ../ && make
Documentation to be added in #351