Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CommitApi file endpoint #131

Open
nickb-carallon opened this issue Feb 27, 2021 · 6 comments
Open

CommitApi file endpoint #131

nickb-carallon opened this issue Feb 27, 2021 · 6 comments

Comments

@nickb-carallon
Copy link

Hey, it's currently possible to query the contents of a file in a commit (rather than all the files in that commit) via the Gerrit rest api, however there isn't a method for this exposed in the CommitApi java class. I was wondering if I wanted to add this to your project, would I first need to add a method for it to the main Gerrit repo, or would it be okay to just add here?

@EFregnan
Copy link
Contributor

Hi, thank you for pointing this out.

The files in the src/main/java/com/google directory are periodically synched with the ones of the main Gerrit repo.

For this reason, you should first add this functionality in the main Gerrit repo. Then, we will import the modified CommitApi class here and it will be possible to proceed with the implementation.

@uwolfer, do you agree?

@uwolfer
Copy link
Owner

uwolfer commented Mar 1, 2021

@uwolfer, do you agree?

Yes, makes sense to me.

@nickb-carallon: I'd suggest to open an issue against Gerrit, and get feedback whether it makes sense to add to their extensions API. And in that case implement it there first.

@nickb-carallon
Copy link
Author

Okay, thanks for the advice 🙂

@nickb-carallon
Copy link
Author

nickb-carallon commented Mar 2, 2021

After some more reading and pondering, I believe I can accomplish more using the Gitiles plugin for Gerrit (such as retrieving trees as well as files). However it seems that including support for plugin apis here is still under discussion so I may leave making any changes until that discussion has been resolved.

@uwolfer
Copy link
Owner

uwolfer commented Mar 4, 2021

I assume you are talking about #59.

@nickb-carallon
Copy link
Author

Yep, that's the one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants