From b88b4527da5a32fe7a6529ebbb94704a12b1a7a1 Mon Sep 17 00:00:00 2001 From: nscipione Date: Mon, 16 Dec 2024 15:19:09 +0000 Subject: [PATCH] Address PR comments Signed-off-by: nscipione --- docs/building_the_project_with_dpcpp.rst | 13 ++++++------- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/docs/building_the_project_with_dpcpp.rst b/docs/building_the_project_with_dpcpp.rst index a6bcae7f4..90a085f99 100644 --- a/docs/building_the_project_with_dpcpp.rst +++ b/docs/building_the_project_with_dpcpp.rst @@ -59,8 +59,8 @@ or ``clang++`` and ``clang`` respectively when using the Open DPC++ Compiler. Backends should be enabled by setting ``-DENABLE__BACKEND=True`` for each desired backend. By default, only the ``MKLGPU`` and ``MKLCPU`` backends are enabled. Multiple backends for multiple device vendors can be -enabled at once (albeit with limitations when using oneMath SYCL BLAS and portFFT). The -supported backends for the compilers are given in the table at `oneMath +enabled at once (albeit with limitations when using oneMath generic SYCL BLAS and portFFT). +The supported backends for the compilers are given in the table at `oneMath supported configurations table `_, and the CMake option names are given in the table below. Some backends may @@ -247,7 +247,7 @@ unsupported configurations. Pure SYCL backends: generic BLAS and portFFT ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ -`Generic BLAS `_ and `portFFT +`Generic SYCL BLAS `_ and `portFFT `_ are experimental pure-SYCL backends that work on all SYCL targets supported by the DPC++ compiler. Since they support multiple targets, they cannot be enabled with other backends in the @@ -257,7 +257,7 @@ experimental and currently only support a subset of operations and features. For best performance, both libraries must be tuned. See the individual sections for more details. -Both oneMath SYCL BLAS and portFFT are used as header-only libraries, and will be +Both generic SYCL BLAS and portFFT are used as header-only libraries, and will be downloaded automatically if not found. .. _build_for_generic_blas_dpcpp: @@ -270,7 +270,7 @@ enabled by setting ``-DENABLE_GENERIC_BLAS_BACKEND=True``. By default, the generic BLAS backend is not tuned for any specific device. This tuning is required to achieve best performance. -OneMath SYCL BLAS can be tuned for a specific hardware target by adding compiler +The generic SYCL BLAS backend can be tuned for a specific hardware target by adding compiler definitions in 2 ways: #. @@ -438,8 +438,7 @@ Build oneMath for the BLAS domain on a generic SYCL device: -DENABLE_GENERIC_BLAS_BACKEND=True Note that this is not a tested configuration. This builds oneMath with the -generic BLAS backend only, for a generic SYCL device supported by the -Open DPC++ project. +generic SYCL BLAS backend only, for a generic SYCL device. Build oneMath for the DFT domain on a generic SYCL device: