Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

oneMKL build instruction improvements #38

Closed
rodburns opened this issue Mar 22, 2024 · 5 comments
Closed

oneMKL build instruction improvements #38

rodburns opened this issue Mar 22, 2024 · 5 comments
Assignees
Milestone

Comments

@rodburns
Copy link
Contributor

rodburns commented Mar 22, 2024

The build instructions for oneMKL could be clearer, in particular for the Nvidia and AMD backends but also for using an open source backend such as portBLAS.
It would benefit the community if there was clearer information on the project README on how to build the project from source and link to different back end libraries. For example this PR outlines one of the improvements.

Acceptance Criteria:

  • Clear instructions for anyone to compile oneMKL from source with any of the available backends
  • Instructions have been reviewed by community members
@rodburns rodburns converted this from a draft issue Mar 22, 2024
@rodburns rodburns changed the title oneMKL build instructions oneMKL build instruction improvements Mar 22, 2024
@rodburns rodburns added this to the Q2 2024 milestone Mar 25, 2024
@Rbiessy
Copy link
Collaborator

Rbiessy commented Mar 27, 2024

Note that we also started an open issue in uxlfoundation/oneMath#459
We will probably start this work ourselves when we have the time but other contributions are more than welcome!

@vbm23
Copy link
Collaborator

vbm23 commented Jun 11, 2024

uxlfoundation/oneMath#510 opened and waiting for 2nd review approval

@vbm23
Copy link
Collaborator

vbm23 commented Jun 20, 2024

@vbm23
Copy link
Collaborator

vbm23 commented Jun 20, 2024

@mkrainiuk Based on the above 2 MRs, would you consider this meets the acceptance criteria for this issue?

@mkrainiuk
Copy link
Collaborator

Yes, I think it was great improvement for the build instructions. I will close the task.

@github-project-automation github-project-automation bot moved this from In Progress to Done in Open Source Best Practices Jun 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

4 participants