-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent fix-up commits from being merged #543
Conversation
Mmmmm, do I need to add a license to the file for the workflow :-? |
yes, please
|
and you should able to run REUSE locally before pushing. Do you have the pre-commit hooks installed? https://github.com/uyuni-project/uyuni-tools/blob/main/README.md#install-pre-commit-hooks |
https://github.com/uyuni-project/uyuni-tools/blob/main/README.md#install-pre-commit-hooks says:
But I am using python 3.6 and the package doesn't exist on Leap 15.6? What else is missing? Do the instructions miss adding a repository? |
9e0be2f
to
5880fbb
Compare
@@ -0,0 +1,16 @@ | |||
# SPDX-FileCopyrightText: 2021 Bradley Erickson | |||
# | |||
# SPDX-License-Identifier: MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The action and this configuration comes from https://github.com/13rac1/block-fixup-merge-action/blob/master/README.md, and that repo is license as MIT, and 13rac1
is Bradely Erickson, so this should be correct.
5880fbb
to
7e1b65f
Compare
You're right...
I'll see if it's possible to have it in Leap instead of using my custom repo. As alternative, we could build those packages in one of the Uyuni utils repos like tito etc |
I don't see this package using In any case the PR tests are passing now. |
Co-authored-by: Marina Latini <[email protected]>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks
What does this PR change?
Prevent fix-up commits from being merged.
Port of uyuni-project/uyuni#9773 from the
uyuni
repository.After this PR is merged, I will force the test to pass for the
main
branch.Test coverage
No tests: None, this is adding an action
DONE
Links
Issue(s): None
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Before you merge
Check How to branch and merge properly!