New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Readme update - one of the two pending pull requests mentioned has been merged #83

Open

hlovdal opened this issue Feb 17, 2022 · 1 comment

hlovdal commented Feb 17, 2022

The "pending" pull request Fix for MODBUS_GET_* macro is merged and included upstream.

Collaborator

i-ky commented Feb 18, 2022

Readme actually says:

This module doesn't work with the upstream libmodbus lib, so patched libmodbus v3.1.4 library is used underneath and shipped as a submodule.
Two patches are applied:
- Encapsulated Modbus RTU over TCP (libmodbus PR)
- Fix for MODBUS_GET_* macro (libmodbus PR)

Fix for MODBUS_GET_* macro is indeed merged and available in libmodbus 3.1.7.

However, the module still ships libmodbus 3.1.4: https://github.com/v-zhuravlev/libmodbus/blob/014c1f35eb1ff42144995f5f150f385064091f41/configure.ac#L14-L16 ...which still needs both patches.

I think to address this issue properly we need to:

update libmodbus fork from upstream;
update this repository's .gitmodules;
remove mentions of merged PR from readme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment