From c3bd08d36d883dbeed4a259aa67ea7fd34dc8cd4 Mon Sep 17 00:00:00 2001
From: John Wilkie <john@v7labs.com>
Date: Fri, 27 Oct 2023 15:22:14 +0100
Subject: [PATCH] Core delete item method & tests

---
 darwin/future/core/client.py                  |  9 +++-
 darwin/future/core/items/delete_items.py      | 44 +++++++++++++++
 .../tests/core/items/test_delete_items.py     | 54 +++++++++++++++++++
 3 files changed, 105 insertions(+), 2 deletions(-)
 create mode 100644 darwin/future/core/items/delete_items.py
 create mode 100644 darwin/future/tests/core/items/test_delete_items.py

diff --git a/darwin/future/core/client.py b/darwin/future/core/client.py
index 7e6d4387b..d6d287e0e 100644
--- a/darwin/future/core/client.py
+++ b/darwin/future/core/client.py
@@ -219,10 +219,15 @@ def post(self, endpoint: str, data: dict) -> JSONType:
         return self._generic_call(self.session.post, endpoint, data)
 
     def delete(
-        self, endpoint: str, query_string: Optional[QueryString] = None
+        self,
+        endpoint: str,
+        query_string: Optional[QueryString] = None,
+        data: Optional[dict] = None,
     ) -> JSONType:
         return self._generic_call(
-            self.session.delete, self._contain_qs_and_endpoint(endpoint, query_string)
+            self.session.delete,
+            self._contain_qs_and_endpoint(endpoint, query_string),
+            data if data is not None else {},
         )
 
     def patch(self, endpoint: str, data: dict) -> JSONType:
diff --git a/darwin/future/core/items/delete_items.py b/darwin/future/core/items/delete_items.py
new file mode 100644
index 000000000..1fd4d6ae4
--- /dev/null
+++ b/darwin/future/core/items/delete_items.py
@@ -0,0 +1,44 @@
+from typing import Dict, List
+from uuid import UUID
+
+from darwin.future.core.client import ClientCore
+from darwin.future.core.types.common import JSONType
+from darwin.future.data_objects.typing import UnknownType
+
+
+def delete_list_of_items(
+    api_client: ClientCore,
+    team_slug: str,
+    dataset_id: int,
+    item_ids: List[UUID],
+    filters: Dict[str, UnknownType] = {},
+) -> JSONType:
+    """
+    Delete specified items
+
+    Parameters
+    ----------
+    client: Client
+        The client to use for the request
+    team_slug: str
+        The slug of the team containing the items
+    dataset_id: int
+        The ID of the dataset containing the items
+    item_ids: List[UUID]
+        The IDs of the items to be deleted
+    filters: Dict[str, UnknownType]
+        Dataset filter parameters
+
+    Returns
+    -------
+    JSONType
+    """
+    payload = {
+        "filters": {
+            "dataset_ids": [dataset_id],
+            "item_ids": [str(item_id) for item_id in item_ids],
+            **filters,
+        }
+    }
+
+    return api_client.delete(f"/v2/teams/{team_slug}/items", data=payload)
diff --git a/darwin/future/tests/core/items/test_delete_items.py b/darwin/future/tests/core/items/test_delete_items.py
new file mode 100644
index 000000000..cf292d4ec
--- /dev/null
+++ b/darwin/future/tests/core/items/test_delete_items.py
@@ -0,0 +1,54 @@
+from unittest.mock import Mock
+from uuid import UUID
+
+import pytest
+import responses
+
+from darwin.exceptions import DarwinException
+from darwin.future.core.client import ClientCore
+from darwin.future.core.items.delete_items import delete_list_of_items
+from darwin.future.tests.core.fixtures import *
+
+
+@responses.activate
+def test_delete_items_including_filters(base_client: ClientCore) -> None:
+    # Define the expected response
+    responses.add(
+        responses.DELETE,
+        base_client.config.api_endpoint + "v2/teams/test-team/items",
+        json={"affected_item_count": 2},
+    )
+
+    # Call the function
+    response = delete_list_of_items(
+        api_client=base_client,
+        team_slug="test-team",
+        dataset_id=000000,
+        item_ids=[
+            UUID("00000000-0000-0000-0000-000000000000"),
+            UUID("00000000-0000-0000-0000-000000000000"),
+        ],
+        filters={
+            "not_statuses": ["uploading", "annotate"],
+            "not_assignees": [123, 456, 789],
+        },
+    )
+
+    # Check that the response mathces what we expect
+    assert response == {"affected_item_count": 2}
+
+
+def test_delete_items_with_error_response() -> None:
+    api_client = Mock(spec=ClientCore)
+    api_client.delete.side_effect = DarwinException("Something went wrong")
+
+    with pytest.raises(DarwinException):
+        delete_list_of_items(
+            api_client=api_client,
+            team_slug="test-team",
+            dataset_id=000000,
+            item_ids=[
+                UUID("00000000-0000-0000-0000-000000000000"),
+                UUID("00000000-0000-0000-0000-000000000000"),
+            ],
+        )