Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test new JRebel that supports Hotswapper #20452

Closed
4 tasks done
mshabarov opened this issue Nov 12, 2024 · 6 comments
Closed
4 tasks done

Test new JRebel that supports Hotswapper #20452

mshabarov opened this issue Nov 12, 2024 · 6 comments

Comments

@mshabarov
Copy link
Contributor

mshabarov commented Nov 12, 2024

Describe your motivation

Test Vaadin 24.6 and 24.5 with the latest JRebel snapshot, where the Hotswapper API is implemented.

These should be checked:

  • editing, adding a new flow route, deleting a flow route leads to UI refresh
  • Copilot shows a proper status for Java Hotswap
  • Copilot features works (adding new and modifying existing route)
  • editing a translation file leads to server restart and UI refresh
@tepi
Copy link
Contributor

tepi commented Nov 22, 2024

Editing, adding a new flow route, deleting a flow route leads to UI refresh

  • Editing and adding works fine via Copilot and via IDE directly
  • Removing a route class removes it from target folder but route remains available in app

Copilot shows a proper status for Java Hotswap

  • Works fine

Copilot features works (adding new and modifying existing route)

  • Works fine

Editing a translation file leads to server restart and UI refresh

  • When first creating the translations via Copilot, the first refresh leads to Copilot log saying "Error: Failed to get translations"
  • However, editing the newly created translation file in IDE after that loads the changes just fine
  • Also editing the translations via Copilot does reload the change fine

@tepi
Copy link
Contributor

tepi commented Nov 22, 2024

Removing a route class removes it from target folder but route remains available in app

This seems to work the same way with hotswap agent

@mshabarov
Copy link
Contributor Author

Tested with the JRebel Agent 2024.4.2-SNAPSHOT (2024-11-21 11:38) and observed the same testing results as @tepi did with little difference: I got no Copilot error message - it added the translation codes then instructed me to restart the server, I did it, and then I got working refreshes on each modification of translation files.

Note that JRebel doesn't support deleted class case by design.

@tepi
Copy link
Contributor

tepi commented Nov 22, 2024

with little difference: I got no Copilot error message

Tested this two more times, not getting an error message. Could have been something random.

@mshabarov
Copy link
Contributor Author

mshabarov commented Nov 25, 2024

I'm currently investigating the reloading case, when @EventData value is changed and changes are not reflected on the UI, e.g. when the parameter name is wrong in Java, one want to fix it and gets no UI refresh after that.

@mshabarov
Copy link
Contributor Author

Follow up issue - #20548.

I think this testing ticket can be closed now.

@github-project-automation github-project-automation bot moved this from ⚒️ In progress to Done in Vaadin Flow ongoing work (Vaadin 10+) Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

No branches or pull requests

2 participants