fix: exclude project maven dependencies from isolated class loader #20523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user project depends directly or transitively from maven artifacts mojos can fail at runtime because of Maven API loaded from both isolated class loader and maven.api realm. This change prevents maven artifacts to be added to the isolated class loader.
caalador
previously approved these changes
Nov 21, 2024
mshabarov
reviewed
Nov 21, 2024
flow-plugins/flow-dev-bundle-plugin/src/main/java/com/vaadin/flow/plugin/maven/Reflector.java
Outdated
Show resolved
Hide resolved
mshabarov
approved these changes
Nov 21, 2024
|
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
…20523) If the user project directly or transitively depends on maven artifacts, mojos can fail at runtime because of Maven API loaded from both isolated class loader and maven.api realm. This change prevents maven artifacts from being added to the isolated class loader.
vaadin-bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
…20523) If the user project directly or transitively depends on maven artifacts, mojos can fail at runtime because of Maven API loaded from both isolated class loader and maven.api realm. This change prevents maven artifacts from being added to the isolated class loader.
vaadin-bot
added a commit
that referenced
this pull request
Nov 21, 2024
…20523) (#20529) If the user project directly or transitively depends on maven artifacts, mojos can fail at runtime because of Maven API loaded from both isolated class loader and maven.api realm. This change prevents maven artifacts from being added to the isolated class loader. Co-authored-by: Marco Collovati <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Nov 21, 2024
…20523) (#20530) If the user project directly or transitively depends on maven artifacts, mojos can fail at runtime because of Maven API loaded from both isolated class loader and maven.api realm. This change prevents maven artifacts from being added to the isolated class loader. Co-authored-by: Marco Collovati <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user project depends directly or transitively from maven artifacts mojos can fail at runtime because of Maven API loaded from both isolated class loader and maven.api realm.
This change prevents maven artifacts to be added to the isolated class loader.