Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove modal component on route refresh (#20540) (CP: 24.5) #20583

Merged
merged 1 commit into from
Nov 29, 2024
Merged

fix: remove modal component on route refresh (#20540) (CP: 24.5) #20583

merged 1 commit into from
Nov 29, 2024

Commits on Nov 29, 2024

  1. fix: remove modal component on route refresh (#20540) 

    Modal components attached to the UI were not removed or replaced during
self-navigation triggered by a route refresh.
This change updates navigation handler to ensure modal components are
removed and adds a new navigation trigger for route refresh to differentiate
programmatic navigations (e.g., forward actions).
It also modifies Hotswapper to require a full chain refresh when modal
components are present.

Fixes #20473
    @mcollovati @vaadin-bot
    mcollovati authored and vaadin-bot committed Nov 29, 2024
    Configuration menu
    Copy the full SHA
    58c7f24 View commit details
    Browse the repository at this point in the history