From 7996982ed8c5104da2a5cc16394266053e6547f2 Mon Sep 17 00:00:00 2001
From: vahid <vahid4134@gmail.com>
Date: Sun, 25 Feb 2024 18:20:09 +0100
Subject: [PATCH] skip variant test for version before 24

---
 .github/workflows/ci.yaml | 5 +++--
 column/variant_test.go    | 3 +++
 2 files changed, 6 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
index b807254..eb8ede0 100644
--- a/.github/workflows/ci.yaml
+++ b/.github/workflows/ci.yaml
@@ -18,7 +18,7 @@ jobs:
     steps:
     - uses: vahid-sohrabloo/clickhouse-action@v1
       with:
-        version: '23.9'
+        version: '24.1'
 
         
     - name: Set up Go
@@ -41,10 +41,11 @@ jobs:
     strategy:
       matrix:
         golang-version: [1.21, 1.22]
-        clickhouse-version: ['23.9', '23.8', '23.7', '22.3', '22.8']
+        clickhouse-version: [''24.1'', '23.10',','23.9', '23.8', '23.7']
     env:
       VERBOSE: 1
       GOFLAGS: -mod=readonly
+      CLICKHOUSE_VERSION: ${{ matrix.clickhouse-version }}
 
     steps:
     - uses: vahid-sohrabloo/clickhouse-action@v1
diff --git a/column/variant_test.go b/column/variant_test.go
index a02e1d7..a057fe7 100644
--- a/column/variant_test.go
+++ b/column/variant_test.go
@@ -25,6 +25,9 @@ func TestVariant(t *testing.T) {
 	conn, err := chconn.Connect(context.Background(), connString)
 	require.NoError(t, err)
 
+	if conn.ServerInfo().MajorVersion < 24 && conn.ServerInfo().MinorVersion < 1 {
+		t.Skipf("clickhouse-server version %d.%d does not support Variant type", conn.ServerInfo().MajorVersion, conn.ServerInfo().MinorVersion)
+	}
 	err = conn.Exec(context.Background(),
 		fmt.Sprintf(`DROP TABLE IF EXISTS test_%s`, tableName),
 	)