You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I was working on DTN branch and I saw what, in my opinion, is an important error done in design time. The class JSAP violates the Liskov substitution principle (https://en.wikipedia.org/wiki/Liskov_substitution_principle), to be more accurate in that class is written that the JSAP class IS-A SPARQL11SEProperties, but this is not correct. The original thought, probably, was that JSAP class USES the SPARQL11SEProperties class. The JSAP class is an abstraction of a real configuration file, that cannot be itself a collection of properties! This is an important difference that, in my opinion, should be fixed
The text was updated successfully, but these errors were encountered:
I was working on DTN branch and I saw what, in my opinion, is an important error done in design time. The class JSAP violates the Liskov substitution principle (https://en.wikipedia.org/wiki/Liskov_substitution_principle), to be more accurate in that class is written that the JSAP class IS-A SPARQL11SEProperties, but this is not correct. The original thought, probably, was that JSAP class USES the SPARQL11SEProperties class. The JSAP class is an abstraction of a real configuration file, that cannot be itself a collection of properties! This is an important difference that, in my opinion, should be fixed
The text was updated successfully, but these errors were encountered: