Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Violation of Liskov substitution principle in JSAP file #51

Open
andre-bisa opened this issue Sep 12, 2019 · 0 comments
Open

Violation of Liskov substitution principle in JSAP file #51

andre-bisa opened this issue Sep 12, 2019 · 0 comments

Comments

@andre-bisa
Copy link
Collaborator

I was working on DTN branch and I saw what, in my opinion, is an important error done in design time. The class JSAP violates the Liskov substitution principle (https://en.wikipedia.org/wiki/Liskov_substitution_principle), to be more accurate in that class is written that the JSAP class IS-A SPARQL11SEProperties, but this is not correct. The original thought, probably, was that JSAP class USES the SPARQL11SEProperties class. The JSAP class is an abstraction of a real configuration file, that cannot be itself a collection of properties! This is an important difference that, in my opinion, should be fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant