You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Once the NbtPath is parsed, lookups can be performed on &Compound or &mut Compound values.
I would also like to see some unit tests and assurance that our implementation closely matches vanilla Minecraft's behavior.
What alternative(s) have you considered?
This is less of an alternative and more of an addition to the above solution, but we could add methods on Compound (named path, path_mut?) similar to serde_json's pointer and pointer_mut methods. The implementation should not parse to an intermediate NbtPath to avoid the associated overhead.
Describe the problem related to your feature request.
There is currently no support for NBT path format in
valence_nbt
.NBT path format support is a prerequisite for a complete command parser and
valence_command
crate.What solution would you like?
Add a new
path
module and feature flag tovalence_nbt
.Paths get parsed into a structure that looks something like this:
Once the
NbtPath
is parsed, lookups can be performed on&Compound
or&mut Compound
values.I would also like to see some unit tests and assurance that our implementation closely matches vanilla Minecraft's behavior.
What alternative(s) have you considered?
This is less of an alternative and more of an addition to the above solution, but we could add methods on
Compound
(namedpath
,path_mut
?) similar toserde_json
'spointer
andpointer_mut
methods. The implementation should not parse to an intermediateNbtPath
to avoid the associated overhead.Additional context
#332
The text was updated successfully, but these errors were encountered: