Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/topics/introduction.md needs updated language about 'support' #111

Open
stockholmux opened this issue May 28, 2024 · 1 comment
Open

/topics/introduction.md needs updated language about 'support' #111

stockholmux opened this issue May 28, 2024 · 1 comment

Comments

@stockholmux
Copy link
Member

In pre-publishing review (#91), I found the following passage on /topics/introduction.md

Valkey is written in ANSI C and works on most POSIX systems like Linux, *BSD, and Mac OS X, without external dependencies. Linux and OS X are the two operating systems where Valkey is developed and tested the most, and we recommend using Linux for deployment. Valkey may work in Solaris-derived systems like SmartOS, but support is best effort. There is no official support for Windows builds.

This has a few issues:

  • Mac OS X / OS X -> MacOS
  • Valkey may work in Solaris-derived systems like SmartOS to my knowledge Valkey has been tested on anything Solaris derived
  • There is no official support for Windows builds. -> Maybe talk about WSL?
@zuiderkwast
Copy link
Contributor

We receive Solaris related contributions from time to time, so I believe some people run this. Illumos is a more recent variant I believe. We don't have any CI for it though, so I believe "may work" is appropriate, for now (until someone adds a CI job for it). Solaris is POSIX so it should work.

Regarding Windows, I wouldn't want to dive into that swamp. If we do mention WSL, should we go into MinGW and Cygwin too? I believe windows users can figure this out, or use a VM, if they persist running a non-Posix system.

The name of MacOS is the one thing that's clearly worth fixed here IMO.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants