Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/topics/sentinel-clients.md has outdated references and terminology, mentions non-existent google group #132

Closed
stockholmux opened this issue May 31, 2024 · 1 comment · Fixed by #153

Comments

@stockholmux
Copy link
Member

In pre-publishing review (#91) I noticed several issues with /topics/sentinel-clients.md

If the ROLE commands is not available (it was introduced in Redis OSS 2.8.12), a client may resort to the INFO replication command parsing the role: field of the output.

and

Starting with Redis OSS 2.8.12

Remove reference to 2.8.12

For additional information or to discuss specific aspects of this guidelines, please drop a message to the Valkey Google Group.

There isn't a Valkey Google group, so this should be deleted.

Finally, there are 44 references that need to be updated to primary

@zuiderkwast
Copy link
Contributor

Addressing this, except "master" which I'm leaving for #148

zuiderkwast added a commit to zuiderkwast/valkey-doc that referenced this issue Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants