Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/topics/twitter-clone.md lacks code highlighting and should switch to Valkey in one case #138

Closed
stockholmux opened this issue May 31, 2024 · 0 comments · Fixed by #153
Closed

/topics/twitter-clone.md lacks code highlighting and should switch to Valkey in one case #138

stockholmux opened this issue May 31, 2024 · 0 comments · Fixed by #153

Comments

@stockholmux
Copy link
Member

In the pre-publishing review (#91), I discovered a couple small issues with /topics/twitter-clone.md

After 5 years there were many cases of applications using Redis OSS as their main store, so the goal of the article today is to be a tutorial for newcomers.

I would remove the relative year note and switch Redis OSS to Valkey

Additionally, the PHP examples should use backticks and specify a highlighter for better readability.
@stockholmux stockholmux changed the title /topics/twitter-clone.md /topics/twitter-clone.md lacks code highlighting and should switch to Valkey in one case May 31, 2024
zuiderkwast added a commit to zuiderkwast/valkey-doc that referenced this issue Jul 3, 2024
@zuiderkwast
Address comments for twitter-clone.md, fixes valkey-io#138
6c5abd2 
Signed-off-by: Viktor Söderqvist <[email protected]>
@zuiderkwast zuiderkwast mentioned this issue Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Doc review fixes zuiderkwast/valkey-doc
1 participant
@stockholmux