Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Valkey is single-threaded" not good words #196

Open
zuiderkwast opened this issue Dec 9, 2024 · 2 comments
Open

"Valkey is single-threaded" not good words #196

zuiderkwast opened this issue Dec 9, 2024 · 2 comments

Comments

@zuiderkwast
Copy link
Contributor

zuiderkwast commented Dec 9, 2024

IO threading is barely mentioned in the docs. Using a simple grep for "thread", I find that wherever threads are mentioned, it is wrong. We seem to have missed updating the docs while improving I/O threading.

Now, I think we should at least correct the parts that are plain wrong. @uriyage, @ranshid do you want to help with this?

I found the following problems using a simple git grep thread in this repo. (It's old. We've just replaced Redis with Valkey.)

benchmark.md (fixed in #222):

Valkey is, mostly, a single-threaded server from the POV of commands execution (actually modern versions of Valkey use threads for different things). It is not designed to
benefit from multiple CPU cores. People are supposed to launch several Valkey instances to scale out on several cores if needed. It is not really fair to compare one single Valkey instance to a multi-threaded data store.

encryption.md (fixed in #222):

I/O threading is currently not supported with TLS.

faq.md (fixed in #197):

As of version 4.0, Valkey has started implementing threaded actions. For now this is limited to deleting objects in the background and blocking commands implemented via Valkey modules. For subsequent releases, the plan is to make Valkey more and more threaded.

latency-monitor.md:

Finally, Valkey is single threaded. This is usually an advantage

I think we should formulate this differently. It's not single threaded, but the commands are executed sequentially by a single thread. We shouldn't just state that it's single threaded.

latency.md (fixed in #222):

Single threaded nature of Valkey

@zuiderkwast
Copy link
Contributor Author

@ranshid fyi

@uriyage
Copy link
Contributor

uriyage commented Jan 22, 2025

Thanks @zuiderkwast , I will open a PR for it.

zuiderkwast pushed a commit that referenced this issue Feb 27, 2025
Update IO threads documentation. Remove formulations
that say Valkey is single threaded.

#196

---------

Signed-off-by: Uri Yagelnik <[email protected]>
Signed-off-by: uriyage <[email protected]>
Co-authored-by: Madelyn Olson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants