Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task] Add unpublish mechanism on release test failure — just python left. #2735

Open
2 of 3 tasks
avifenesh opened this issue Nov 21, 2024 · 5 comments
Open
2 of 3 tasks
Assignees
Labels
backlog Issues/tasks/etc currentlly part of backlog CI/CD CI/CD related Tech debt
Milestone

Comments

@avifenesh
Copy link
Member

avifenesh commented Nov 21, 2024

Description

Currently, our mechanism is to publish, then test, and if fail the version stay up there broken. After a while, it looks like that:
image

One problem is that looks bad, the second is that if a version is broken, we need to run and manually unpublish, so no user get something broken.

The process needs to be tested, and in case of failure, immediately unpublish.

Checklist

  • 1. node (WIP)
  • 2. python
  • 3. Java?
@avifenesh avifenesh added backlog Issues/tasks/etc currentlly part of backlog CI/CD CI/CD related 1_2_candidate labels Nov 21, 2024
@avifenesh
Copy link
Member Author

@acarbonetto Is it relevant for Java?
@adarovadya while releasing python, can you add it to the WF? I'll be ready with it in node, I guess you can mostly copy.

@avifenesh avifenesh moved this to In Progress in Valkey-GLIDE - internal Nov 21, 2024
@avifenesh avifenesh added this to the 1.2 milestone Nov 21, 2024
@acarbonetto
Copy link
Contributor

This feature is already implemented in Java.

The release pipeline will pull the release candidate from maven/staging if tests fail. See: drop-deployment-if-validation-fails
https://github.com/valkey-io/valkey-glide/blob/main/.github/workflows/java-cd.yml#L291

@avifenesh
Copy link
Member Author

This feature is already implemented in Java.

The release pipeline will pull the release candidate from maven/staging if tests fail. See: drop-deployment-if-validation-fails https://github.com/valkey-io/valkey-glide/blob/main/.github/workflows/java-cd.yml#L291

Always one step ahead 😉

@avifenesh avifenesh changed the title [Task] Add unpublish mechanism on release test failure. [Task] Add unpublish mechanism on release test failure — just python left. Nov 22, 2024
@ikolomi ikolomi removed this from the 1.2 milestone Nov 25, 2024
@asafpamzn asafpamzn added this to the 1.3 milestone Dec 25, 2024
@adarovadya
Copy link
Collaborator

in PyPi- Unfortunately, there's no reliable command-line method to delete packages, as this is intentionally restricted for security reasons. need to find another way

@asafpamzn asafpamzn modified the milestones: 1.3, 1.4 Jan 7, 2025
@avifenesh
Copy link
Member Author

@adarovadya did we close this one?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Issues/tasks/etc currentlly part of backlog CI/CD CI/CD related Tech debt
Projects
Status: In Progress
Development

No branches or pull requests

5 participants