Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing readonly commands. #2649

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Add missing readonly commands. #2649

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
011a8f4
Add missing readonly commands.
Yury-Fridlyand Nov 8, 2024
ac91fae
Merge branch 'release-1.2' into core/add-missing-readonly
Yury-Fridlyand Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@
* Core: Add support for sending multi-slot JSON.MSET and JSON.MGET commands ([#2587]https://github.com/valkey-io/valkey-glide/pull/2587)
* Node: Add `JSON.DEBUG` command ([#2572](https://github.com/valkey-io/valkey-glide/pull/2572))
* Node: Add `JSON.NUMINCRBY` and `JSON.NUMMULTBY` command ([#2555](https://github.com/valkey-io/valkey-glide/pull/2555))
* Core: Fix list of readonly commands ([#2634](https://github.com/valkey-io/valkey-glide/pull/2634), [#2649](https://github.com/valkey-io/valkey-glide/pull/2649))

#### Breaking Changes

Expand Down
19 changes: 18 additions & 1 deletion glide-core/redis-rs/redis/src/cluster_routing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -869,7 +869,23 @@ pub fn is_readonly(routable: &impl Routable) -> bool {
pub fn is_readonly_cmd(cmd: &[u8]) -> bool {
matches!(
cmd,
b"BITCOUNT"
b"ACL CAT"
| b"ACL DELUSER"
| b"ACL DRYRUN"
| b"ACL GENPASS"
| b"ACL GETUSER"
| b"ACL HELP"
| b"ACL LIST"
| b"ACL LOAD"
| b"ACL LOG"
| b"ACL SAVE"
| b"ACL SETUSER"
| b"ACL USERS"
| b"ACL WHOAMI"
| b"AUTH"
| b"BGREWRITEAOF"
| b"BGSAVE"
| b"BITCOUNT"
| b"BITFIELD_RO"
| b"BITPOS"
| b"CLIENT ID"
Expand Down Expand Up @@ -920,6 +936,7 @@ pub fn is_readonly_cmd(cmd: &[u8]) -> bool {
| b"CONFIG SET"
| b"DBSIZE"
| b"DUMP"
| b"ECHO"
| b"EVAL_RO"
| b"EVALSHA_RO"
| b"EXISTS"
Expand Down