Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hexpire exposed even though valkey doesn't support it. #78

Open
NegatioN opened this issue Aug 29, 2024 · 2 comments · May be fixed by #125
Open

hexpire exposed even though valkey doesn't support it. #78

NegatioN opened this issue Aug 29, 2024 · 2 comments · May be fixed by #125
Assignees

Comments

@NegatioN
Copy link

Version: valkey-py: 6.0.0 (installed using pip install "valkey[libvalkey]") valkey: docker container valkey/valkey:8.0

Platform: Python 3.11.6 on Manjaro Linux

Description:
Should hexpire be exposed as a command in Valkey-py if Valkey doesn't support it?
Ideally hexpire is implemented, and everything is fine, but now it seems to be in a weird limbo state.

How to reproduce:

Run container: docker run -it --rm -p 6379:6379 --name valkey valkey/valkey:8.0

python:

import valkey
r = valkey.Valkey(host='localhost', port=6379, db=0)
event = {
     'air_quality': 256,
     'battery_level':89
 }
r.hset('yolo', mapping=event)
r.hexpire('yolo', 60, 'air_quality')
>>> ResponseError: unknown command 'HEXPIRE', with args beginning with: 'yolo' '60' 'FIELDS' '1' 'air_quality' 
@aiven-sal
Copy link
Member

aiven-sal commented Aug 29, 2024

Hi! Thanks for the report!
You are indeed absolutely right!
That command should not be in Valkey-py.
We can remove it in the next major version, for now I think we need to keep it (just in case).
I'll drop it from the doc and keep this issue open as a reminder.
Thanks again!

@aiven-sal aiven-sal self-assigned this Nov 27, 2024
aiven-sal added a commit that referenced this issue Nov 27, 2024
Support for this commands may come in the future[1].
But it will take some time, so for now it's better
to drop them.

This is a breaking change for 6.1.

Close #78

[1]: valkey-io/valkey#640

Signed-off-by: Salvatore Mesoraca <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants
@NegatioN @aiven-sal and others