Renaming thread #9

madolson · 2024-03-22T15:01:47Z

Starting a thread to find ideas for folks to propose alternative naming ideas. If you have an idea, please post it here in a single comment. 👍 for ideas that people like. If your name is not descriptive or clear what it means, also please include a description about why.

madolson · 2024-03-22T15:40:54Z

openkvs

hpatro · 2024-03-22T17:02:53Z

openkv

mullim · 2024-03-22T17:12:42Z

OpenCache

kevinmcgehee · 2024-03-22T18:12:01Z

OpenStruct

viktorix · 2024-03-22T18:50:37Z

Radish 😁

adiologydev · 2024-03-22T19:08:15Z

PrismDB
PrismKV

RealmDB
RealmKV

These are my suggestions :D

joshmanders · 2024-03-22T19:35:03Z

DynamoKV

antstanley · 2024-03-22T19:36:06Z

Redis came from Remote Dictionary Server... so maybe Open Dictionary Server -> Odis

mcollina · 2024-03-22T19:49:18Z

CampoKV, because Salvatore was born in Campobello di Licata.

RussellRollins · 2024-03-22T21:48:04Z

bluewas

bentotten · 2024-03-22T22:42:05Z

Bredis and have it be stacked toast 🍞

bentotten · 2024-03-22T22:51:27Z

Greenis

mswilson · 2024-03-22T23:11:51Z

Dass (DAta Structure Server).

And when you get it as a service, it's DassaaS

madolson · 2024-03-23T00:51:56Z

Keyvi
kivi

Or some similar spelling. I recently went to New Zealand, if you haven't seen kiwi birds they are so adorable!

nichchun · 2024-03-23T01:08:11Z

fledis - For those of us who have "fled" open source Redis after Garantia Data took it

KarthikSubbarao · 2024-03-23T01:29:11Z

Keyvi kivi

Or some similar spelling. I recently went to New Zealand, if you haven't seen kiwi birds they are so adorable!

+1. I was suggesting kiwi earlier since it sounds close to KV (Key-Value).

Conan-Kudo · 2024-03-23T02:09:58Z

This could get... confusing with "kiwi" (an image build tool). I would appreciate it if we didn't do that. :)

rlunar · 2024-03-23T02:48:09Z

OrcaKV
VoltKV (VoltDB already exists)
BrisKV
SwiftKV (I know not this one)
SleeKV

nadav-levanoni · 2024-03-23T02:51:28Z

SalvatoreDB antirezDB

Johno72 · 2024-03-23T06:17:36Z

Whodis
Newdis

rbtcollins · 2024-03-23T06:47:03Z

bluedis

PingXie · 2024-03-23T06:53:12Z

"KV" is likely selling this project short IMO. I also feel that we should move on from "*dis". What happened has happened. Let's move on and build something amazing with a clean image for the community. There are plenty of other options to connect with the former Redis community members/users.

nadav-levanoni · 2024-03-23T07:30:49Z

MemoryDB

Redis has more functionality than a simple key-value store, and this name is generic and quick to understand universally.

This conflicts with the existing MemoryDB service which may be an issue.

franck-chester · 2024-03-23T08:06:35Z

oops-i-redis-again
re-redis

vithalreddy · 2024-03-23T09:01:45Z

EmberDB

rudygt · 2024-03-23T09:05:11Z

ReVo (redis evolution)

kkofler · 2024-03-23T11:01:15Z

Maybe a play on musical notes? "Redis" is "DD#": "re" is Latin for "D", "dis" is German for "D#". There are a lot of names that could be thought up based on this theme.

deanlj · 2024-03-23T12:10:31Z

ReOpen but may have trademark conflicts

riferrei · 2024-03-23T12:25:35Z

OpenRedis?

It worked pretty for OpenSearch, with a name that clearly states the goal of the project: being the [true] open-source version of Elasticsearch. Also, I agree with others about the K/V semantics. Redis is far more than just a key-value store. It's vast set of supported data structures is what makes it so flexible and powerful.

natoscott · 2024-03-27T01:32:03Z

okiwis is the best shortening we can come up with in this case to keep it distinctive enough.

'kiwis' is just fine and rolls off the tongue IMO. 'okiwis' adds a syllable and sounds like a mistake when you say it out loud ("oh, kiwis").

OK, that's enough bike shedding for me. :)

viktorix · 2024-03-27T01:57:10Z

quiwi or quiwe both pronounced kiwi 😄
qui in French is pronounced as ki in kiwi. So technically, in English it would be whowe 🤣

vongosling · 2024-03-27T04:37:33Z

Second OpenKV, or say, RainbowKV. Hope that after the rainbow, our new products will be more open and the community will thrive.

rphlmr · 2024-03-27T06:25:12Z

Oredis
Open Remote Dictionary Server.

chinguyen21 · 2024-03-27T07:27:24Z

OpenIMDb
Open In-memory Database.

martialblog · 2024-03-27T08:14:53Z

Sider - Redis spelled backwards... also a different spelling of cider 🍏 Who doesn't like fermented apple juice!

zuiderkwast · 2024-03-27T10:27:03Z

Many good points. Let's come up with a 5-letter name that isn't similar to any other software name. I live on an island called Orust.

CRConrad · 2024-03-27T16:06:11Z

and odis user is taken in github. Before suggesting a name I suggest to check if it is available at least on github.

So Microsoft now owns the very namespace of open source projects? (Or is this just a symptom of kids just barely old enough to know what a file is, but not old enough to know that GitHub is not the same as git?)

madolson · 2024-03-27T16:13:26Z

So Microsoft now owns the very namespace of open source projects? (Or is this just a symptom of kids just barely old enough to know what a file is, but not old enough to know that GitHub is not the same as git?)

Although that is A problem, it's not THE problem. The problem is that we're concerned people (the average consumer) might legitimately think it stands for "open redis", which is something we need to avoid for legal reasons.

CRConrad · 2024-03-27T16:36:17Z

Phoenix, like rising from the ashes. Not bad.

Dig deep down in the history files and you'll find out how the Firefox browser got its name... Yes, they, too, started from Phoenix.

bjosv · 2024-03-27T17:25:36Z

Additional ideas for a 5-letter name:

Keval - key-value but squashed..
Clavi - declension of the Latin word for key.

..naming is hard for sure.

elroyPDX · 2024-03-27T20:08:16Z

keester - Key Store

jamietanna · 2024-03-28T16:58:53Z

Valkey 👀 https://www.linuxfoundation.org/press/linux-foundation-launches-open-source-valkey-community

zuiderkwast · 2024-03-28T17:03:01Z

Yes! Do you like the name? I'm closing this thread but you can continue commenting here on the name if you want. Thank you for all suggestions!

Conan-Kudo · 2024-03-28T17:15:35Z

Valkey is a great name! 👍🏾

joshmanders · 2024-03-28T17:33:16Z

Thank you for not going with anything revolving around kiwi, I don't know why but it didn't jive with me.

PenguRinTwo · 2024-03-28T17:42:49Z

That's an awesome name

kkofler · 2024-03-29T19:21:07Z

Kinda disappointing that we are being asked for suggestions and then a name gets picked that was not suggested here (making the attempt at involving the community kinda pointless), but otherwise I see no issue with the name Valkey.

joshmanders · 2024-03-29T20:10:56Z

Kinda disappointing that we are being asked for suggestions and then a name gets picked that was not suggested here (making the attempt at involving the community kinda pointless), but otherwise I see no issue with the name Valkey.

The suggestion could have been made elsewhere not just this thread.

YohannesTz · 2024-03-29T20:22:12Z

Safo

zuiderkwast · 2024-03-29T20:29:17Z

@kkofler I'm sorry you feel that way. It has been a chaos of discussions in multiple forums. All suggestions have been considered. Many of the suggestions were rejected, either by LF or by somebody else, because of trademark issues (too similar to redis or some other trademark according to the idea of "likelihood of confusion" in trademark law) or because of collision with some other name. Another thing is that we were a little afraid that if we post a name, someone else can register the domain name before we do it.

YohannesTz · 2024-03-29T20:34:21Z

@kkofler I'm sorry you feel that way. It has been a chaos of discussions in multiple forums. All suggestions have been considered. Many of the suggestions were rejected, either by LF or by somebody else, because of trademark issues (too similar to redis or some other trademark according to the idea of "likelihood of confusion" in trademark law) or because of collision with some other name. Another thing is that we were a little afraid that if we post a name, someone else can register the domain name before we do it.

I understand but I don't get how "Safo" could remotely be close to "redis". anyways ggs

zuiderkwast · 2024-03-29T20:42:14Z

@YohannesTz ????

kkofler · 2024-03-29T20:44:07Z

Your "Safo" suggestion came too late, the name is already decided.

PatrickJS · 2024-03-30T03:47:28Z

@kkofler I'm sorry you feel that way. It has been a chaos of discussions in multiple forums. All suggestions have been considered. Many of the suggestions were rejected, either by LF or by somebody else, because of trademark issues (too similar to redis or some other trademark according to the idea of "likelihood of confusion" in trademark law) or because of collision with some other name. Another thing is that we were a little afraid that if we post a name, someone else can register the domain name before we do it.

this is a really great explanation as I did kind of feel the same way thinking it was more likely OpenKV/OpenKVS but given all things the team has to consider it's understandable.

madolson · 2024-03-31T04:09:56Z

this is a really great explanation as I did kind of feel the same way thinking it was more likely OpenKV/OpenKVS but given all things the team has to consider it's understandable.

OpenKV was also considered a high risk because there were other comparable names. I was hoping we would go with that too after all the more fun names got rejected :/

PatrickJS · 2024-04-01T02:32:51Z

long live Valkey

here's some random logos

…is missed cases to redis-server. (#12322) Observed that the sanitizer reported memory leak as clean up is not done before the process termination in negative/following cases: **- when we passed '--invalid' as option to redis-server.** ``` -vm:~/mem-leak-issue/redis$ ./src/redis-server --invalid *** FATAL CONFIG FILE ERROR (Redis 255.255.255) *** Reading the configuration file, at line 2 >>> 'invalid' Bad directive or wrong number of arguments ================================================================= ==865778==ERROR: LeakSanitizer: detected memory leaks Direct leak of 8 byte(s) in 1 object(s) allocated from: #0 0x7f0985f65867 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145 valkey-io#1 0x558ec86686ec in ztrymalloc_usable_internal /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:117 valkey-io#2 0x558ec86686ec in ztrymalloc_usable /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:135 valkey-io#3 0x558ec86686ec in ztryrealloc_usable_internal /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:276 valkey-io#4 0x558ec86686ec in zrealloc /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:327 valkey-io#5 0x558ec865dd7e in sdssplitargs /home/ubuntu/mem-leak-issue/redis/src/sds.c:1172 valkey-io#6 0x558ec87a1be7 in loadServerConfigFromString /home/ubuntu/mem-leak-issue/redis/src/config.c:472 valkey-io#7 0x558ec87a13b3 in loadServerConfig /home/ubuntu/mem-leak-issue/redis/src/config.c:718 valkey-io#8 0x558ec85e6f15 in main /home/ubuntu/mem-leak-issue/redis/src/server.c:7258 valkey-io#9 0x7f09856e5d8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 SUMMARY: AddressSanitizer: 8 byte(s) leaked in 1 allocation(s). ``` **- when we pass '--port' as option and missed to add port number to redis-server.** ``` vm:~/mem-leak-issue/redis$ ./src/redis-server --port *** FATAL CONFIG FILE ERROR (Redis 255.255.255) *** Reading the configuration file, at line 2 >>> 'port' wrong number of arguments ================================================================= ==865846==ERROR: LeakSanitizer: detected memory leaks Direct leak of 8 byte(s) in 1 object(s) allocated from: #0 0x7fdcdbb1f867 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145 valkey-io#1 0x557e8b04f6ec in ztrymalloc_usable_internal /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:117 valkey-io#2 0x557e8b04f6ec in ztrymalloc_usable /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:135 valkey-io#3 0x557e8b04f6ec in ztryrealloc_usable_internal /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:276 valkey-io#4 0x557e8b04f6ec in zrealloc /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:327 valkey-io#5 0x557e8b044d7e in sdssplitargs /home/ubuntu/mem-leak-issue/redis/src/sds.c:1172 valkey-io#6 0x557e8b188be7 in loadServerConfigFromString /home/ubuntu/mem-leak-issue/redis/src/config.c:472 valkey-io#7 0x557e8b1883b3 in loadServerConfig /home/ubuntu/mem-leak-issue/redis/src/config.c:718 valkey-io#8 0x557e8afcdf15 in main /home/ubuntu/mem-leak-issue/redis/src/server.c:7258 valkey-io#9 0x7fdcdb29fd8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 Indirect leak of 10 byte(s) in 1 object(s) allocated from: #0 0x7fdcdbb1fc18 in __interceptor_realloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:164 valkey-io#1 0x557e8b04f9aa in ztryrealloc_usable_internal /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:287 valkey-io#2 0x557e8b04f9aa in ztryrealloc_usable /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:317 valkey-io#3 0x557e8b04f9aa in zrealloc_usable /home/ubuntu/mem-leak-issue/redis/src/zmalloc.c:342 valkey-io#4 0x557e8b033f90 in _sdsMakeRoomFor /home/ubuntu/mem-leak-issue/redis/src/sds.c:271 valkey-io#5 0x557e8b033f90 in sdsMakeRoomFor /home/ubuntu/mem-leak-issue/redis/src/sds.c:295 valkey-io#6 0x557e8b033f90 in sdscatlen /home/ubuntu/mem-leak-issue/redis/src/sds.c:486 valkey-io#7 0x557e8b044e1f in sdssplitargs /home/ubuntu/mem-leak-issue/redis/src/sds.c:1165 valkey-io#8 0x557e8b188be7 in loadServerConfigFromString /home/ubuntu/mem-leak-issue/redis/src/config.c:472 valkey-io#9 0x557e8b1883b3 in loadServerConfig /home/ubuntu/mem-leak-issue/redis/src/config.c:718 valkey-io#10 0x557e8afcdf15 in main /home/ubuntu/mem-leak-issue/redis/src/server.c:7258 valkey-io#11 0x7fdcdb29fd8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58 SUMMARY: AddressSanitizer: 18 byte(s) leaked in 2 allocation(s). ``` As part analysis found that the sdsfreesplitres is not called when this condition checks are being hit. Output after the fix: ``` vm:~/mem-leak-issue/redis$ ./src/redis-server --invalid *** FATAL CONFIG FILE ERROR (Redis 255.255.255) *** Reading the configuration file, at line 2 >>> 'invalid' Bad directive or wrong number of arguments vm:~/mem-leak-issue/redis$ =========================================== vm:~/mem-leak-issue/redis$ ./src/redis-server --jdhg *** FATAL CONFIG FILE ERROR (Redis 255.255.255) *** Reading the configuration file, at line 2 >>> 'jdhg' Bad directive or wrong number of arguments --------------------------------------------------------------------------- vm:~/mem-leak-issue/redis$ ./src/redis-server --port *** FATAL CONFIG FILE ERROR (Redis 255.255.255) *** Reading the configuration file, at line 2 >>> 'port' wrong number of arguments ``` Co-authored-by: Oran Agra <[email protected]>

Fixes #796 Currently rioConnWite uses 1024 bytes chunk when feeding the replication sockets on RDB write. This value seems too small and we will end up with high syscall overhead. **This PR sets the max chunk size to 16K.** Using a simple test program we did not observe any significant improvement in read/write times going with chunks bigger than 4K but that might be la bottleneck on network throughput. We did observe sweet point of CPU utilization at 16K when using TLS. ``` lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description: Ubuntu 24.04 LTS Release: 24.04 Codename: noble ``` ``` uname -a Linux ip-172-31-22-140 6.8.0-1009-aws #9-Ubuntu SMP Fri May 17 14:39:23 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux ``` All files were compiled with O3 optimization level. ``` gcc --version gcc (Ubuntu 13.2.0-23ubuntu4) 13.2.0 ``` **Results:** Chunk Size | write-time sec | writes total | write cpu-time (usr+sys) | read-time sec | read total syscalls | read cpu-time (usr+sys) -- | -- | -- | -- | -- | -- | -- 1K | 0.162946 | 102400 | 0.185916 | 0.168479 | 2447 | 0.026945 4K | 0.163036 | 25600 | 0.122629 | 0.168627 | 715 | 0.023382 8K | 0.163942 | 12800 | 0.121131 | 0.168887 | 704 | 0.039388 16K | 0.163614 | 6400 | 0.104742 | 0.168202 | 2483 | 0.025574 64K | 0.16279 | 1600 | 0.098792 | 0.168854 | 1068 | 0.046929 1K - TLS | 0.32648 | 102400 | 0.366961 | 0.330785 | 102400 | 0.337377 4K - TLS | 0.164296 | 25600 | 0.183326 | 0.169032 | 25600 | 0.129952 8K - TLS | 0.163977 | 12800 | 0.163118 | 0.169484 | 12800 | 0.098432 16K - TLS | 0.164861 | 6400 | 0.150666 | 0.169878 | 6383 | 0.094794 64K - TLS | 0.163704 | 6400 | 0.156125 | 0.169323 | 6388 | 0.089971 --------- Signed-off-by: Ran Shidlansik <[email protected]> Signed-off-by: ranshid <[email protected]> Signed-off-by: Binbin <[email protected]> Co-authored-by: Madelyn Olson <[email protected]> Co-authored-by: Binbin <[email protected]>

madolson changed the title ~~Remaning thread~~ Renaming thread Mar 22, 2024

zuiderkwast closed this as completed Mar 28, 2024

Renaming thread #9

Renaming thread #9

Comments

madolson commented Mar 22, 2024 • edited Loading

madolson commented Mar 22, 2024

hpatro commented Mar 22, 2024

mullim commented Mar 22, 2024

kevinmcgehee commented Mar 22, 2024

viktorix commented Mar 22, 2024

adiologydev commented Mar 22, 2024

joshmanders commented Mar 22, 2024

antstanley commented Mar 22, 2024

mcollina commented Mar 22, 2024

RussellRollins commented Mar 22, 2024

bentotten commented Mar 22, 2024

bentotten commented Mar 22, 2024

mswilson commented Mar 22, 2024

madolson commented Mar 23, 2024 • edited Loading

nichchun commented Mar 23, 2024 • edited Loading

KarthikSubbarao commented Mar 23, 2024 • edited Loading

Conan-Kudo commented Mar 23, 2024

rlunar commented Mar 23, 2024 • edited Loading

nadav-levanoni commented Mar 23, 2024

Johno72 commented Mar 23, 2024

rbtcollins commented Mar 23, 2024

PingXie commented Mar 23, 2024

nadav-levanoni commented Mar 23, 2024 • edited Loading

franck-chester commented Mar 23, 2024

vithalreddy commented Mar 23, 2024

rudygt commented Mar 23, 2024

kkofler commented Mar 23, 2024

deanlj commented Mar 23, 2024

riferrei commented Mar 23, 2024

natoscott commented Mar 27, 2024

viktorix commented Mar 27, 2024

vongosling commented Mar 27, 2024 • edited Loading

rphlmr commented Mar 27, 2024

chinguyen21 commented Mar 27, 2024

martialblog commented Mar 27, 2024

zuiderkwast commented Mar 27, 2024 • edited Loading

CRConrad commented Mar 27, 2024

madolson commented Mar 27, 2024

CRConrad commented Mar 27, 2024

bjosv commented Mar 27, 2024

elroyPDX commented Mar 27, 2024

jamietanna commented Mar 28, 2024

zuiderkwast commented Mar 28, 2024

Conan-Kudo commented Mar 28, 2024

joshmanders commented Mar 28, 2024

PenguRinTwo commented Mar 28, 2024

kkofler commented Mar 29, 2024

joshmanders commented Mar 29, 2024

YohannesTz commented Mar 29, 2024

zuiderkwast commented Mar 29, 2024

YohannesTz commented Mar 29, 2024

zuiderkwast commented Mar 29, 2024

kkofler commented Mar 29, 2024

PatrickJS commented Mar 30, 2024 • edited Loading

madolson commented Mar 31, 2024

PatrickJS commented Apr 1, 2024 • edited Loading

long live Valkey

madolson commented Mar 22, 2024 •

edited

Loading

madolson commented Mar 23, 2024 •

edited

Loading

nichchun commented Mar 23, 2024 •

edited

Loading

KarthikSubbarao commented Mar 23, 2024 •

edited

Loading

rlunar commented Mar 23, 2024 •

edited

Loading

nadav-levanoni commented Mar 23, 2024 •

edited

Loading

vongosling commented Mar 27, 2024 •

edited

Loading

zuiderkwast commented Mar 27, 2024 •

edited

Loading

PatrickJS commented Mar 30, 2024 •

edited

Loading

PatrickJS commented Apr 1, 2024 •

edited

Loading