Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add option to white icons #71

Open
Josse4Cats opened this issue Nov 29, 2022 · 6 comments
Open

Please add option to white icons #71

Josse4Cats opened this issue Nov 29, 2022 · 6 comments

Comments

@Josse4Cats
Copy link

Hi team

Sorry I have try to make the icon white and i dont´t find any way for this ..

@kbhors
Copy link

kbhors commented Jun 10, 2023

Well it's now June 2023 and you received no reply. I don't think the dev checks the issues page.

I also need to make the icon white. With the popularity of dark themes it's crazy there's apparently no battery monitors we can use!

@valr
Copy link
Owner

valr commented Jun 11, 2023

Hi @Josse4Cats, @kbhors,
I must admit I forgot to reply to this, indeed.

I'm not sure how the have the icons white.
The tool only refers to existing icon sets installed on the machine.
It doesn't apply any change on them, and the gtk_status_icon_xxx functions don't seem such option available.

Would you know any tool having such option so that I could look at the code how it's done?
Thanks

@valr
Copy link
Owner

valr commented Jun 11, 2023

Could you try if the merged code #55 makes any difference to this issue?
Thanks

@kbhors
Copy link

kbhors commented Jun 11, 2023

Hi @Josse4Cats, @kbhors, I must admit I forgot to reply to this, indeed.

I'm not sure how the have the icons white. The tool only refers to existing icon sets installed on the machine. It doesn't apply any change on them, and the gtk_status_icon_xxx functions don't seem such option available.

Would you know any tool having such option so that I could look at the code how it's done? Thanks

Eventually I gave up and simply changed the icon set. Which is a shame, because I don't see why icon sets should have anything to do with systray items. Icons are for files and folders. A systray item is fundamentally a button.

@valr
Copy link
Owner

valr commented Jun 12, 2023

@Josse4Cats, @kbhors,
Would you have the possibility to test if the code that has been merged (PR #55) makes any difference to this issue?

The original explanation for the PR #55 is the following:
"Currently cbatticon does not use the system configured Icons and Theme (.config/gtk-3.0/settings.ini). On my system this has the effect, that icons appear in the wrong color (dark icon on dark background)"
So, it may be related.

@mrgreen3
Copy link

Bit late to the party but I am having the same issue, Openbox running tint2 I have dark icon on a dark background. i3wm it works fine. As a workaround I have a coloured background in this case green. Really would like icon colour to be either white or add an option. If you need any output then please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants