Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Like duplication #16

Open
vandie opened this issue Aug 29, 2022 · 1 comment
Open

Like duplication #16

vandie opened this issue Aug 29, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@vandie
Copy link
Owner

vandie commented Aug 29, 2022

Currently, it is possible for the same domain to send multiple likes to the handler and them both be processed. While this is perfectly acceptable, they can also be from the same author which can lead to multiple likes from the same user appearing next to one another.

This is especially an issue when using Bridgy to handle social media likes where a user can like the page using multiple sites that link back to their primary web domain. That web domain then provides an author object which is the same for both likes. This can happen (in an even more troubling manner) when receiving likes from Twitter as these can be duplicated due to the same user liking multiple tweets that act as substitutes for the same web page. In this case the likes are almost identical but still have a different source and therefore cannot be de-duplicated.

While the official web mention spec doesn't offer a solution to this issue, and therfore it may be out of scope. It seems like this should be handled or at very least, documentation should be added that explains the limitation and offers suggestions on how to solve it.

@vandie vandie added the bug Something isn't working label Aug 29, 2022
@vandie
Copy link
Owner Author

vandie commented Sep 3, 2022

I'm leaning towards making documenting this as won't fix. Its expected functionality according to the webmention spec and I'm hesitant to deviate from spec.

I'll add an explanation on how to fix it for a given site though as it can be fixed in a single line (which I have done over on mikevdv.dev)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant