Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Out of date documention re Jasmine #60

Open
xavier-taylor opened this issue May 29, 2020 · 0 comments
Open

Out of date documention re Jasmine #60

xavier-taylor opened this issue May 29, 2020 · 0 comments

Comments

@xavier-taylor
Copy link

Hi there,

I am maintaining some old code at my company that happens to use Vandium and Jasmine, and I am adding some tests to the code as I go about working with it.

I think the comment here:
https://github.com/vandium-io/lambda-tester/blob/master/docs/test-frameworks.md

"Jasmine does not support Promises as return types, and thus requires an additional step when verifying Lambda handlers. Tests should be set to use asynchronous operation using the done callback and also requires verify() to be used with tests."

is out of date. I am no Jasmine expert (never used it before today), but it seems like Jasmine does now support Promises as return types, if I understood your meaning correctly.

See https://jasmine.github.io/tutorials/async

Thanks for your work providing and maintaining these libraries.

Best Regards,

Xavier Taylor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant