Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix keyboard with customize keyboard #306

Closed
wants to merge 1 commit into from

Conversation

chihung93
Copy link

Customize for fixing emoji on some specialist devices

@vanniktech
Copy link
Owner

Thanks for starting to work on this. Can anyone who's gotten the issue from #191 verify that this does fix the issue as I can't reproduce? @daniele-athome @danielgaribaldi @186538

@daniele-athome
Copy link

I could try with my user's way of reproducing the issue. I'll let you know. Thanks @chihung93!

@vanniktech
Copy link
Owner

@daniele-athome any news?

@daniele-athome
Copy link

Sorry for being late. I've been testing the sample app, the close-keyboard-before-showing-emoji mechanism works, but there is something wrong with the detection of the keyboard height, so the EditText moves up and down between keyboard and emojis. I might do something to fix that (I already do it in my code), but I have a couple of questions:

  • EditText cursor disappears because the view loses focus (it shouldn't lose it. Right?)
  • I guess the keyboard height is not handled automatically by your view but it has to be provided via setKeyboardHeight
  • AFAICU the emoji panel is hidden when the EditText is clicked. I feel like it's wrong. OnClick might not be the only event that triggers the keyboard (what about OnFocus? Or anything else)

I feel I can somehow contribute to this, but I can't promise anything on short term. Anyway I'll have to work on this sooner or later :-)

@vanniktech
Copy link
Owner

Regarding your first question yes.
Yeah custom keyboard height needs to be considered. We might even need to special case the notch on some devices.
OnFocus like selecting the text should also dismiss it.

Thanks for picking this up in the future!

@vanniktech
Copy link
Owner

This is super old now and in a state on which we can't advance further. Hence I'm closing this but willing to reconsider once the PR reaches a mergeable state.

@vanniktech vanniktech closed this Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants