ASLPieceMover bug

[derimmer]

Related to boardZoomer changes

vassalengine/modules#2816

[derimmer]

See also vassalengine/modules#2811

vassalengine/modules#2812

[derimmer]

See ref to QC menu in this one: vassalengine/modules#2804

[derimmer]

Another boardZoomer related bug - vassalengine/modules#2805

[derimmer]

VASSAL issues 2811, 2812, and 2816 all involve the same error, caused by ASLPieceMover,DragHandlerNoImage.dragGestureRecognized(). It is not clear to me how to handle this error. Nor have I been able to determine what causes it. It clearly has something to do with moving counters but does not happen in every instance.

VASSAL issue 2804 involves a call to PieceMover rather than ASLPieceMover. Again, I cannot replicate the error.

VASSAL issue 2805 involves a call to ASLPieceMover but again I cannot replicate the error.

It is not clear to me how to handle any of the errors.

Best approach at present is to wait for more occurences and try and get more detailed information about what user action triggered it.

[uckelman]

2804 might be a bug in Java.

Your problem in 2805 is here:

final ASLMap map = (ASLMap) firstPiece.getMap();
double pZoom = map.PieceScalerBoardZoom(firstPiece);

You can be dragging a piece which has no map, e.g., if it's being dragged off the piece palette. The bounding box is supposed to be unscaled; do whatever scaling you need to do outside of this function and you won't need to get a map here at all.

2811, 2812, and 2816 happen because you have a setDrawWinToOwnerOf which is a no-op and it doesn't cause drawWin to be set like it should. You need it to have the same body as the one in Vassal.

It would in general be better to override only the drag handler parts you need to override instead of copying it wholesale out of Vassal. The latter is what caused 2811, 2812, and 2816---your copy fell behind.

[derimmer]

Adding a commit to fix another minor bug in ASLPieceMover.

[derimmer]

See also discussion in pull request #1744