From c767e2a03179bc63d37ae027cdd2680340372e55 Mon Sep 17 00:00:00 2001
From: Alan Jowett <alan.jowett@microsoft.com>
Date: Thu, 17 Oct 2024 12:17:25 -0700
Subject: [PATCH] Add tests for store and atomic store

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
---
 src/assertions.cpp    |   1 +
 test-data/uninit.yaml | 180 ++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 181 insertions(+)

diff --git a/src/assertions.cpp b/src/assertions.cpp
index 9bb558419..3356bfeab 100644
--- a/src/assertions.cpp
+++ b/src/assertions.cpp
@@ -196,6 +196,7 @@ class AssertExtractor {
         res.emplace_back(TypeConstraint{ins.access.basereg, TypeGroup::pointer});
         res.emplace_back(
             ValidAccess{ins.access.basereg, ins.access.offset, Imm{static_cast<uint32_t>(ins.access.width)}, false});
+        res.emplace_back(TypeConstraint{ins.valreg, TypeGroup::number});
         if (ins.op == Atomic::Op::CMPXCHG) {
             // The memory contents pointed to by ins.access will be compared
             // against the value of the ins.valreg register.  Only numbers are
diff --git a/test-data/uninit.yaml b/test-data/uninit.yaml
index 62fe32fef..77c984257 100644
--- a/test-data/uninit.yaml
+++ b/test-data/uninit.yaml
@@ -315,3 +315,183 @@ post:
   - "r0.svalue=r3.svalue"
   - "r0.type=r3.type"
   - "r0.uvalue=r3.uvalue"
+
+---
+test-case: Store uninitialized register to context - 8 bytes
+
+pre:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+code:
+  <start>: |
+    *(u64 *)(r1 + 0) = r0
+
+post:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+messages:
+  - "0: Only numbers can be stored to externally-visible regions (r1.type != stack -> r0.type == number)"
+
+---
+test-case: Store uninitialized register to context - 4 bytes
+
+pre:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+code:
+  <start>: |
+    *(u32 *)(r1 + 0) = r0
+
+post:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+messages:
+  - "0: Invalid type (r0.type == number)"
+
+---
+test-case: Store uninitialized register to context - 2 bytes
+
+pre:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+code:
+  <start>: |
+    *(u16 *)(r1 + 0) = r0
+
+post:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+messages:
+  - "0: Invalid type (r0.type == number)"
+
+---
+test-case: Store uninitialized register to context - 1 bytes
+
+pre:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+code:
+  <start>: |
+    *(u8 *)(r1 + 0) = r0
+
+post:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+messages:
+  - "0: Invalid type (r0.type == number)"
+
+---
+test-case: Atomic add uninitialized register to context
+
+pre:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+code:
+  <start>: |
+    lock *(u64 *)(r1 + 0) += r5
+
+post:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+messages:
+  - "0: Invalid type (r5.type == number)"
+
+---
+test-case: Atomic AND uninitialized register to context
+
+pre:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+code:
+  <start>: |
+    lock *(u64 *)(r1 + 0) &= r5
+
+post:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+messages:
+  - "0: Invalid type (r5.type == number)"
+
+---
+test-case: Atomic OR uninitialized register to context
+
+pre:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+code:
+  <start>: |
+    lock *(u64 *)(r1 + 0) |= r5
+
+post:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+messages:
+  - "0: Invalid type (r5.type == number)"
+
+---
+test-case: Atomic XOR uninitialized register to context
+
+pre:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+code:
+  <start>: |
+    lock *(u64 *)(r1 + 0) |= r5
+
+post:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+messages:
+  - "0: Invalid type (r5.type == number)"
+
+---
+test-case: Atomic XHNG uninitialized register to context
+
+pre:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+code:
+  <start>: |
+    lock *(u64 *)(r1 + 0) x= r5
+
+post:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+messages:
+  - "0: Invalid type (r5.type == number)"
+
+---
+test-case: Atomic CMPXCHG uninitialized register to context
+
+pre:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+code:
+  <start>: |
+    lock *(u64 *)(r1 + 0) cx= r5
+
+post:
+  - "r1.type=ctx"
+  - "r1.ctx_offset=0"
+
+messages:
+  - "0: Invalid type (r5.type == number)"