Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

💡 [REQUEST] - Review the migration of the Ledger HW Wallet repo to the SDK #1532

Open
freemanzMrojo opened this issue Nov 25, 2024 · 2 comments

Comments

@freemanzMrojo
Copy link
Member

freemanzMrojo commented Nov 25, 2024

Summary

Review whether it makes sense to migrate this to the SDK https://github.com/dinn2018/hw-app-vet and do so if the answer is yes.

@darrenvechain
Copy link
Member

One important thing is that the above repo is hard to use, specifically:

    public async getAppConfiguration() {
        const response = await this.transport
            .send(
                0xE0,
                0x06,
                0x00,
                0x00,
                Buffer.alloc(0),
                [StatusCodes.OK]
            )
        return response.slice(0, 4)
    }

This returns config values in a single byte array if I remember correctly, eg:

  • App version
  • Are multi clauses enabled?
  • Are contract calls enabled?

Might be nice to explicitly expose these functions

@darrenvechain
Copy link
Member

darrenvechain commented Nov 25, 2024

Also, when signing a very large TX with large clauses etc. (eg contract deployments), the signTranasction can take a really long time with no feedback. VeWorld handles this by passing a callback function to return % complete:

https://github.com/vechain/veworld-extension/blob/150334194b92749456245855795e5a6e7a5dacdf/src/common/ledger/VETLedgerApp.ts#L77

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants