retry_on does not work with until_executed strategy

[hovo]

I have the following ActiveJob declaration with Sidekiq backend, and noticed that the job is not re-enqueued when an error is raised that has a retry_on declaration. I would have expected the job to retry.

class ExampleJob < ApplicationJob
  unique :until_executed on_conflict: :log
  retry_on ExampleError, wait: :polynomially_longer, attempts: 5
  
 end 

[dewski]

You can fix this by creating a file at lib/active_job/uniqueness/strategies/until_executed_patch.rb:

# frozen_string_literal: true

require "active_job/uniqueness/strategies/until_executed"

module ActiveJob
  module Uniqueness
    module Strategies
      class UntilExecutedPatch < UntilExecuted
        def before_enqueue
          return if lock(resource: lock_key, ttl: lock_ttl)
          # We're retrying the job, so we don't need to lock again
          return if job.executions > 0

          handle_conflict(resource: lock_key, on_conflict: on_conflict)
          abort_job
        end
      end
    end
  end
end

In config/application.rb add the following to the end of the file:

require_relative "../lib/active_job/uniqueness/strategies/until_executed_patch"

Update your unique call to use the patched strategy:

class ExampleJob < ApplicationJob
  unique :until_executed_patch
end