Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/faction_ships.py mentions the "koala" ship type which never made it through the csv split in 2013 #11

Open
evertvorster opened this issue Jul 5, 2020 · 0 comments
Milestone

Comments

@evertvorster
Copy link
Contributor

When in doubt, rip it out. This patch gets rid of the koala not found on the console:
Also, quite sneakily, there is a ".stock" which is a ship type that does not exist anymore that is cured with this patch, too.

--- src/Assets-Production/modules/faction_ships.py.orig 2020-07-05 07:40:17.647391353 +0200
+++ src/Assets-Production/modules/faction_ships.py 2020-07-05 07:41:02.312256290 +0200
@@ -416,13 +416,13 @@
("Mule","Plowshare","Llama","Quicksilver","Entourage"),#shaper_citizen
("Mule","Plowshare","Llama"),#unadorned_citizen
("Mule","Llama","Plowshare","Mule","Llama","Plowshare","GTIO","Quicksilver","Diligence","H496","Entourage"),#purist_citizen

  •                    ("Koala","Koala","Hyena","Llama","H496"),#forsaken_citizen
    
  •                    ("Koala","Llama","Llama","Llama","Quicksilver","H496"),#LIHW_citizen
    
  •                    ("Koala","Koala","Koala","Dodo","Llama","Entourage"),#uln_citizen
    
  •                    ("Koala","Dodo","Quicksilver"), #dgn_citizen
    
  •                    ("Hyena","Llama","H496"),#forsaken_citizen
    
  •                    ("Llama","Llama","Llama","Quicksilver","H496"),#LIHW_citizen
    
  •                    ("Dodo","Llama","Entourage"),#uln_citizen
    
  •                    ("Dodo","Quicksilver"), #dgn_citizen
                       ("Kafka","Kafka","Sartre","Llama",), #klkk_citizen
    
  •                    ("Koala","Kafka","Llama"),#mechanist_citizen
    
  •                    ("Koala","Koala","Kafka","Kafka","Sartre"),#shmrn_citizen
    
  •                    ("Kafka","Llama"),#mechanist_citizen
    
  •                    ("Kafka","Kafka","Sartre"),#shmrn_citizen
    
          )
    

isBomber = {"Areus":6,"Taizong":8,"Pacifier":5,"Goddard":4,"Kierkegaard":5,"Hammer":16,"Admonisher":10,"Areus":6,"Taizong":8,"Pacifier":5,"Goddard":4,"Hammer":16,"Admonisher":10}
@@ -657,7 +657,7 @@
from difficulty import usingDifficulty
if (useStock[faction] and usingDifficulty()):
# DON'T USE .blanks directly if possible-- preserve as templates. Use .stock where possible

  •    return ".stock"
    
  •    return ""
    
    else:
    return ""
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants