Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

units.json and ships.json has a lot of cruft #53

Open
royfalk opened this issue Nov 25, 2024 · 3 comments
Open

units.json and ships.json has a lot of cruft #53

royfalk opened this issue Nov 25, 2024 · 3 comments
Milestone

Comments

@royfalk
Copy link
Contributor

royfalk commented Nov 25, 2024

Examples:

{
        "Key": "idun",
        "Textual_Description": "\"The Rlaan Shizu is in many ways similar to its Confederate counterpart, the Schroedinger, meant more for reconaissance and scouting patrols than heavy combat.  Nonetheless, its twin gun mountings allow it to mount a basic defense, should it come under attack.\"\n"
    },
    {
        "Key": "idun.blank",
        "Textual_Description": "\"The Rlaan Shizu is in many ways similar to its Confederate counterpart, the Schroedinger, meant more for reconaissance and scouting patrols than heavy combat.  Nonetheless, its twin gun mountings allow it to mount a basic defense, should it come under attack.\"\n"
    },
    {
        "Key": "lodur",
        "Textual_Description": "\"Rlaan cruiser\"\n"
    },
    {
        "Key": "lodur.blank",
        "Textual_Description": "\"Rlaan cruiser\"\n"
    },
    {
        "Key": "thrud",
        "Textual_Description": "\"Rlaan mass production fighter\"\n"
    },
    {
        "Key": "thrud.blank",
        "Textual_Description": "\"Rlaan mass production fighter\"\n"
    },
    {
        "Key": "vark",
        "Textual_Description": "\"A venerable Aeran destroyer, the Agasicles is designed far more for screening efforts than for capital engagements, but is nimble for a ship its size and dangerous in close quarters.\"\n"
    },
    {
        "Key": "vark.blank",
        "Textual_Description": "\"A venerable Aeran destroyer, the Agasicles is designed far more for screening efforts than for capital engagements, but is nimble for a ship its size and dangerous in close quarters.\"\n"
    },
    {
        "Key": "vidar",
        "Textual_Description": "\"Rlaan mass production assault craft\"\n"
    },
    {
        "Key": "vidar.blank",
        "Textual_Description": "\"Rlaan mass production assault craft\"\n"
    },
    {
        "Key": "vitik",
        "Textual_Description": "\"A carrier built on a scale of paranoid grandeur, this Aeran vessel is as much mobile base as anything else, packing sufficient supplies for prolonged engagements with contested supply lines.\"\n"
    },
    {
        "Key": "vitik.blank",
        "Textual_Description": "\"A carrier built on a scale of paranoid grandeur, this Aeran vessel is as much mobile base as anything else, packing sufficient supplies for prolonged engagements with contested supply lines.\"\n"
    },
    {
        "Key": "yavok",
        "Textual_Description": "\"The Dreadnaught of the modern day, these Aeran battleships pack so many innovations and so much firepower into a single vessel that it is unfair to categorize it with other battlecruisers or battleships.\"\n"
    },
    {
        "Key": "yavok.blank",
        "Textual_Description": "\"The Dreadnaught of the modern day, these Aeran battleships pack so many innovations and so much firepower into a single vessel that it is unfair to categorize it with other battlecruisers or battleships.\"\n"
    },
    {
        "Key": "yrilan",
        "Textual_Description": "\"Aeran cruiser, of venerable tenure of service.\"\n"
    },
    {
        "Key": "yrilan.blank",
        "Textual_Description": "\"Aeran cruiser, of venerable tenure of service.\"\n"
    },

Also, these are sort of duplicates of add_spec_capacitor*__upgrades

{
     "Key": "spec_capacitor01__upgrades",
     "Textual_Description": "\"@upgrades/reactor_capacitance.png@Capacitor for storing energy for FTL travel\"\n"
 },
 {
     "Key": "spec_capacitor02__upgrades",
     "Textual_Description": "\"@upgrades/reactor_capacitance.png@Capacitor for storing energy for FTL travel\"\n"
 },
 {
     "Key": "spec_capacitor03__upgrades",
     "Textual_Description": "\"@upgrades/reactor_capacitance.png@Capacitor for storing energy for FTL travel\"\n"
 },
 {
     "Key": "spec_capacitor04__upgrades",
     "Textual_Description": "\"@upgrades/reactor_capacitance.png@Capacitor for storing energy for FTL travel\"\n"
 },

There's much more like this.

@BenjamenMeyer BenjamenMeyer added this to the 0.10.x milestone Dec 7, 2024
@yowshi
Copy link

yowshi commented Feb 22, 2025

i think the spec capacitor upgrades allow you jump hold more energy so you can jump/ftl bigger ships. not sure they are complete cruft.

@royfalk
Copy link
Contributor Author

royfalk commented Feb 23, 2025

You missed the fact that these are duplicates. The ones in the game are called mult_spec_capacitor*__upgrades and have actual figures. These don't have mass, volume or ftl_energy. If you managed to add them to the game, they wouldn't do anything.

@yowshi
Copy link

yowshi commented Feb 23, 2025

you are right, and some of the text files in the units/factions folders seem to be dupes of entries in units.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants