spontaneous cloaking device

[yowshi]

i've seen it on my llama.begin and now my plowshare where i spontaneously get a cloaking device.

[royfalk]

Please specify the following:

• branches
• ship model
• screenshot if possible
• json of ship from save game if possible

[yowshi]

this particular one is running sgtugg's Vega-Strike-Engine-Source-fix-FTL_0.9.x, assuming this is an engine issue and not an asset issue.
assets are latest deb and i have seen this on the the 0.9.0beta2 version of the engine.
i dont know what actually causes it i think i missed it's initial happening and just kind of noticed it during one of my play sessions.

Llama.begin.csv

Plowshare.stock.csv

[royfalk]

If I had to guess, cloak.cpp

   if(UnitCSVFactory::GetVariable(unit_key, "Can_Cloak", false)) {
        status = CloakingStatus::ready;
    } else {
        status = CloakingStatus::disabled;
    }

is where things are going wrong. I don't see the issue but the old assets used 0, false, FALSE interchangeably. It's possible one of these if read incorrectly as true. It's almost certain.

Either fix the GetVariable for boolean to support all or fix the assets.