From 090e1af9e3eca2c2d65ad2f929df74221108a03c Mon Sep 17 00:00:00 2001
From: Benjamen Meyer <bm_witness@yahoo.com>
Date: Sun, 21 Apr 2024 16:42:00 -0400
Subject: [PATCH] Bug Fix: Mac/Windows Release Builds

- Rename the workflows to match reality (Release not CI)
- Remove the final publisher as it does not support Mac/Win, only
  Linux. A new publisher will be needed to support those platforms
---
 .github/workflows/Windows-Release.yml | 17 +++++++++--------
 .github/workflows/macos-release.yml   | 17 +++++++++--------
 2 files changed, 18 insertions(+), 16 deletions(-)

diff --git a/.github/workflows/Windows-Release.yml b/.github/workflows/Windows-Release.yml
index 7cb4e38872..19792fe845 100644
--- a/.github/workflows/Windows-Release.yml
+++ b/.github/workflows/Windows-Release.yml
@@ -1,4 +1,4 @@
-name: Windows-CI
+name: Windows-Release
 
 # Controls when the action will run.
 on:
@@ -111,10 +111,11 @@ jobs:
           GTEST_COLOR: 1
         run: .\script\test.ps1 -Generator ${{ matrix.cmake-generator }} -EnablePIE ${{ matrix.enable-pie }} -BuildType ${{ matrix.build-type }}
 
-      - name: Upload artifacts 
-        uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
-        with:
-          path: "${{ github.workspace }}/**/*.zip"
+      # TODO: Find/write a tool to upload release for Windows
+      # - name: Upload artifacts
+      #  uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
+      #  env:
+      #    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      #    ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
+      #  with:
+      #    path: "${{ github.workspace }}/**/*.zip"
diff --git a/.github/workflows/macos-release.yml b/.github/workflows/macos-release.yml
index f2c437a901..da624d59eb 100644
--- a/.github/workflows/macos-release.yml
+++ b/.github/workflows/macos-release.yml
@@ -1,4 +1,4 @@
-name: 'MacOS-CI'
+name: 'MacOS-Release'
 
 on:
   release:
@@ -99,10 +99,11 @@ jobs:
           GTEST_COLOR: 1
         run: ctest -V
 
-      - name: Upload the artifacts
-        uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
-        with:
-          args: "packages/*.${{ matrix.ARTIFACT_EXT }}"
+      # TODO: Find/write a tool to upload release for Mac OS
+      # - name: Upload the artifacts
+      #  uses: skx/github-action-publish-binaries@44887b225ceca96efd8a912d39c09ad70312af31 # master
+      #  env:
+      #    GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+      #    ARTIFACT_EXT: ${{ matrix.ARTIFACT_EXT }}
+      #  with:
+      #    args: "packages/*.${{ matrix.ARTIFACT_EXT }}"