Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit whether to keep code that references Boost version 1.28 #797

Open
stephengtuggy opened this issue Sep 15, 2023 · 2 comments
Open

Comments

@stephengtuggy
Copy link
Contributor

          This is archeological. Version 1.54 is from 1999 and it is 105400. https://www.boost.org/doc/libs/1_54_0/boost/version.hpp

Originally posted by @royfalk in #789 (comment)

@BenjamenMeyer
Copy link
Member

what is our minimum Boost version required? 1.55? 1.65? I think we could probably drop some things that are only meant for older versions that we actually do not use any more. I'd suggest we use the following guidance:

Support what is necessary to continue supporting the minimum version of a library.

We may need to have a page setup with a matrix for what is supported on each platform to help with these decisions since we're trying not to bundle stuff ourselves but rely on platform support.

@stephengtuggy
Copy link
Contributor Author

I agree that Boost version 1.28 is quite ancient. And, in general, our minimum supported Boost version could almost certainly be 1.65 or higher.

However, I think that 1.28 may be a special case, used by the game to determine whether a particular bit of Python code is running in the "normal" embedded Python environment, or in some sort of weird "internal" Python environment that was present in 0.5.x. At least, that's the impression I get from studying the code. I could be wrong though.

@Loki1950 @ministerofinformation @danielrh do you guys have any further insight to add on this subject?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants