-
-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Loss of flight controls in newly created save file. #898
Comments
Guessing this will apply to 0.9.x too |
Correction - #893 did not introduce this. It introduce the capability to serialize a resource int the format of: current / max_damaged / max However, it did not introduce any code that uses it. The actual bug is probably in #896 (@evertvorster please confirm). The Yaw_Governor_Left/Yaw_Governor_Right save a value of 0.01/0.01/0.01. It shouldn't be too hard to figure out why. |
This bug is fixed! Yay! |
Sorry. I fixed it but didn't link the PR to it. |
Hmm, this bug was present in master before #986 was merged. I think Benjamin also noticed some loss of Yaw controls a while back, when loading a save file. |
Yes, I've noticed loss of yaw on and off. Usually occurred when launching. Not sure I've seen it in master in a while...but I don't get to play often right now. Will keep an eye out for it. |
This bug was introduced by #893
When running a new campaign and immediately saving the game, the saved game now contains three values separated by a slash in the governors for the flight controls.
The values are also quite low, so the flight controls are almost non-existent.
For reference here is a save file created by the 0.8.x version of the game engine:
Llama.begin.csv
And here is a save file created after that pull request was merged:
Llama.begin.csv
The text was updated successfully, but these errors were encountered: