Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Visual Studio 2017 Toolset #13

Open
manison opened this issue Jan 28, 2019 · 1 comment
Open

Support for Visual Studio 2017 Toolset #13

manison opened this issue Jan 28, 2019 · 1 comment

Comments

@manison
Copy link
Contributor

manison commented Jan 28, 2019

I created PR #12 that adds support for building DCS package with Visual Studio 2017 toolset. This blindly copies the existing definitions for VS2010 and VS2015, however it becomes a bit messy. I think it could be simplified by using the wildcards, so eg. the following lines

RELEASE_VS2010x86_X64_CC_FLAGS    =  /D_UEFI
DEBUG_VS2010x86_X64_CC_FLAGS    = /D_UEFI
NOOPT_VS2010x86_X64_CC_FLAGS    = /D_UEFI

RELEASE_VS2015x86_X64_CC_FLAGS    =  /D_UEFI
DEBUG_VS2015x86_X64_CC_FLAGS    = /D_UEFI
NOOPT_VS2015x86_X64_CC_FLAGS    = /D_UEFI

RELEASE_VS2017_X64_CC_FLAGS    =  /D_UEFI
DEBUG_VS2017_X64_CC_FLAGS    = /D_UEFI
NOOPT_VS2017_X64_CC_FLAGS    = /D_UEFI

could be rewritten as

MSFT:*_*_X64_CC_FLAGS = /D_UEFI

Would you be interested if I further modify the INF files in this way?
This was referenced Jan 28, 2019
Merged
Closed
@manison manison mentioned this issue Feb 6, 2019
Closed
@DavidXanatos
Copy link

What are the new build instructions for building the EFI bootloader with VS 2017?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@manison @DavidXanatos