Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow overriding Router
I was trying to follow the example in the HttpServer example to set this up but a few parts kept bugging. Namely that
require('router')
is not a function. I don't know if this works on other systems and is just a by product of using webpack to package a server, but I've addedconfig.router
so that you can specify the direct expressjs import by doingIt'll still default to the 'router' package if the
config.router
option isn't specified.Switch node-fetch for cross-fetch
I know
cross-fetch
is worse because it's basically a super polyfill for node and browsers without the Fetch API, butnode-fetch
doesn't seem to work with webpacking either, so I figured that I'd bring a sledgehammer to hammer a nail