Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use async? #5

Open
cocowalla opened this issue Jul 3, 2017 · 0 comments
Open

Use async? #5

cocowalla opened this issue Jul 3, 2017 · 0 comments
Labels
up-for-grabs

Comments

@cocowalla
Copy link

Given that the sink is IO bound, would it make more sense to use EmitBatchAsync instead of EmitBatch?

You seem to go to lengths to ensure everything runs synchronously using GetAwaiter().GetResult(), so I'm wondering if there was a reason for that?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
up-for-grabs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@vermeeca @cocowalla