-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Major regressions between 3.5 and 3.6 #82
Comments
Second one seems like mine error during porting to plain java codegen. I'm trying to reproduce it without success. Can you share the generated code involved? |
Maybe I'm wrong, but seems like the error is thrown by rx codegen (I'm testing with 3.6.0.CR1). Proxy and handler are generated correctly:
Looking inside generated classes, everything seems fine |
What shall we do with this one? Is it documentation only? |
For me this is breaking, it worked before, and the same code could not be upgraded directly to 3.6. |
I will try to fix today and see if that is expected or not to require In 3.6 it has been decoupled, so the fix or not will depend on what makes most sense, but it's not a strong thing. We might also make Stay tuned |
do you have a ready reproducer to use @jponge ? |
I will try build the guide and remove the |
so there are two separate issues highlighted in this issue right ? |
The best reproducer is here: vert-x3/vertx-guide-for-java-devs@a0617b5#diff-3ded3ce14c17ee0f03d4b71f8b2787b8R38 Yes, there are 2 issues: one for static methods but in my other Vert.x examples this seems to have been fixed, while the other is still present ( |
I'm hitting the rxjava issue and I think it comes from the fact that proxies have been decoupled from vertx-codegen. Before it was a weird thing, i.e something annotated with Now, since we need to have both I think the solution is that I will make a PR to demonstrate. |
here is the PR vert-x3/vertx-guide-for-java-devs#58 |
@vietj it's good to have a PR for the guide. But I believe we should also
document the breaking change.
|
Can we close it? |
Yep |
While upgrading code from 3.5.x to 3.6 (the guide for Java developers), I encountered 2 regressions.
Need for
@VertxGen
We now need to also add
@VertxGen
.Before:
After:
Otherwise, compilation fails.
Static methods aren't being ignored anymore
Code generation used to ignore static methods, such as the idiomatic
create
methods we have in services:We now need to explicitly ignore them otherwise compilation fails:
The text was updated successfully, but these errors were encountered: