Check Frame if it is a Received or a Sent frame

[johnfoldager]

I'd like to be able to check if a frame is a received frame or a frame that is sent. I can check on the frame.getCommand() for all kinds of frame types and based on that I can make some logic that tells whether it is a received frame or a sent frame based on whether I do client logic or server logic. However, I can't find a good way around checking if a PING frame is a received one or a sent one.

[cescoffier]

That's an interesting use case. Do you need to handle PING frames, as they are used for heartbeat, they are not (should not be) related to your application logic.

[johnfoldager]

I'm working on a sniffer component that needs to be able to check if the client or the server is fx. not sending PING frames every x second. Just one use case.

[cescoffier]

Some random thoughts:

• what about customizing this: https://github.com/vert-x3/vertx-stomp/blob/master/src/main/java/io/vertx/ext/stomp/impl/DefaultStompHandler.java#L518

• what about registering a custom handler: https://github.com/vert-x3/vertx-stomp/blob/master/src/main/java/io/vertx/ext/stomp/StompServerHandler.java#L58

[johnfoldager]

Maybe I could do that, but wouldn't it be nice if it was possible from the Frame object to determine whether it is an outgoing or incoming frame?

[cescoffier]

We can add this feature, fancy a PR ?

[johnfoldager]

Is PR a Pull Request? I'm not into the Vert.x source yet or the Git and GitHub terminologies and probably can't do this just yet, but I'd like to find out how to contribute to the project soon.

[cescoffier]

Yes, a PR is a pull request. Here is seems straightforward:

1. Add a field to the Frame class (probably boolean such as received)
2. Set this field when a frame is received