From 5961a6fffca72124c7ccb2e3f258a45084c55a5b Mon Sep 17 00:00:00 2001 From: Neeraj319 Date: Wed, 8 Jan 2025 12:55:52 +0000 Subject: [PATCH] fix: remove unused tests --- python_client/tests/test_utils.py | 32 +++++++++++++------------------ 1 file changed, 13 insertions(+), 19 deletions(-) diff --git a/python_client/tests/test_utils.py b/python_client/tests/test_utils.py index daaabc5..7fd73c1 100644 --- a/python_client/tests/test_utils.py +++ b/python_client/tests/test_utils.py @@ -15,12 +15,12 @@ locatr_go_cleanup, read_data_over_socket, send_data_over_socket, - spawn_locatr_process, + wait_for_socket, ) from locatr.exceptions import ( - LocatrBinaryNotFound, LocatrClientServerVersionMisMatch, LocatrSocketError, + LocatrSocketNotAvailable, ) @@ -44,12 +44,6 @@ def test_locatr_go_cleanup(self): process.kill.assert_called_once() self.assertFalse(os.path.exists(SocketFilePath.path)) - def test_spawn_locatr_process(self): - try: - spawn_locatr_process(["arg1", "arg2"]) - except LocatrBinaryNotFound: - self.fail("LocatrBinaryNotFound was raised unexpectedly!") - def test_create_packed_message(self): message = "test message" packed_message = create_packed_message(message) @@ -58,17 +52,17 @@ def test_create_packed_message(self): ) self.assertEqual(packed_message, expected_message) - # @patch("socket.socket.connect") - # def test_wait_for_socket(self, mock_connect): - # mock_connect.side_effect = [socket.error] * 5 + [None] - # sock = MagicMock() - # sock.connect = mock_connect - # wait_for_socket(sock) - # self.assertEqual(mock_connect.call_count, 6) - - # mock_connect.side_effect = socket.error - # with self.assertRaises(LocatrSocketNotAvailable): - # wait_for_socket(sock) + @patch("socket.socket.connect") + def test_wait_for_socket(self, mock_connect): + mock_connect.side_effect = [socket.error] * 5 + [None] + sock = MagicMock() + sock.connect = mock_connect + wait_for_socket(sock) + self.assertEqual(mock_connect.call_count, 6) + + mock_connect.side_effect = socket.error + with self.assertRaises(LocatrSocketNotAvailable): + wait_for_socket(sock) @patch("socket.socket.send") def test_send_data_over_socket(self, mock_send):