Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Update Spark Connector formatting #379

Open
jeremyprime opened this issue Apr 26, 2022 · 0 comments
Open

[FEATURE] Update Spark Connector formatting #379

jeremyprime opened this issue Apr 26, 2022 · 0 comments
Labels
enhancement New feature or request Low Priority

Comments

@jeremyprime
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

The formatting/code style throughout the Spark Connector is not consistent, and does not always follow a best practice or standard. This can make reading the code more difficult, and also introduces unnecessary changes when different developers are working on the code and creating pull requests.

Describe the solution you'd like

Come up with a formatting convention that works across IDEs (Visual Studio Code, IntelliJ, etc) and provide instructions in CONTRIBUTING.md on how to apply the formatting. And also apply those formatting rules to the existing codebase in a single PR.

Additional context

I think scalafmt works for both VS Code and IntelliJ. Another option is to use Metals (which is integrated with VS Code, not sure about its support in IntelliJ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Low Priority
Projects
None yet
Development

No branches or pull requests

2 participants