Config filename hard-coded to metrics/vertica-prometheus-exporter.yml

[hhromic]

Hi @verticacrossman,
Here is the first issue we found yesterday while testing this exporter.

The logger implementation uses metrics/vertica-prometheus-exporter.yml as hard-coded fname for the config file for obtaining the logging configuration here:

vertica-prometheus-exporter/cmd/vertica-prometheus-exporter/logger.go

Lines 30 to 34 in f161ef4

	func SetupLogger(configFile string) {
	yfile, err1 := ioutil.ReadFile("metrics/vertica-prometheus-exporter.yml")
	if err1 != nil {
	log.Fatal(err1)
	}

This means that currently is impossible to start the Vertica exporter with a config file NOT in metrics/vertica-prometheus-exporter.yml:

# simplest example is to just rename `metrics` in the repo to something else
$ mv metrics other
$ ./vertica-prometheus-exporter -config.file other/vertica-prometheus-exporter.yml
INFO[2023-01-19T11:33:02Z] Starting vertica exporter (version=v1.0.2, branch=main, revision=becca378611ba84b2b40c5dd8aeb698443bf8fe0) (go=go1.19.2, user=root@USNPrabhu01, date=20221025-16:18:53)
INFO[2023-01-19T11:33:02Z] Loading configuration from other/vertica-prometheus-exporter.yml
INFO[2023-01-19T11:33:02Z] Loaded collector "example" from other/vertica-example.collector.yml
INFO[2023-01-19T11:33:02Z] Loaded collector "example1" from other/vertica-example1.collector.yml
INFO[2023-01-19T11:33:02Z] [collector="example"] Non-zero min_interval (10s), using cached collector.
INFO[2023-01-19T11:33:02Z] [collector="example1"] Non-zero min_interval (10s), using cached collector.
(0xa97620,0xc0000d2a00)
FATA[2023-01-19T11:33:02Z] open metrics/vertica-prometheus-exporter.yml: no such file or directory

The code should use configFile instead of the hard-coded name in ReadFile().

[verticacrossman]

@hhromic Thanks for this feedback. So the issue is that we allow you to use --config_file when starting the exporter, but the logger expects to find it's configuration options in a specific path/config file. This one is clear and we'll add to our list of fixes for the next release.